From f8cfc0230909077d2e378c829ffeb7bdf71a890e Mon Sep 17 00:00:00 2001 From: Elena Oat Date: Thu, 27 Feb 2014 12:26:52 +0200 Subject: [PATCH] Staging: usbip: Fix the warning of unchecked sscanf return value. The return value of sscanf in stub_dev.c is not checked. This patch adds the checking of the return value. Signed-off-by: Elena Oat Signed-off-by: Greg Kroah-Hartman --- drivers/staging/usbip/stub_dev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c index b0bfd3430d47..60a3e3fe4dcb 100644 --- a/drivers/staging/usbip/stub_dev.c +++ b/drivers/staging/usbip/stub_dev.c @@ -87,13 +87,16 @@ static ssize_t store_sockfd(struct device *dev, struct device_attribute *attr, int sockfd = 0; struct socket *socket; ssize_t err = -EINVAL; + int rv; if (!sdev) { dev_err(dev, "sdev is null\n"); return -ENODEV; } - sscanf(buf, "%d", &sockfd); + rv = sscanf(buf, "%d", &sockfd); + if (rv != 1) + return -EINVAL; if (sockfd != -1) { dev_info(dev, "stub up\n"); -- 2.30.2