From f7275dedd4f9a9ab818ca96a6336464a6718514d Mon Sep 17 00:00:00 2001 From: INAGAKI Hiroshi Date: Sat, 16 Mar 2024 19:12:20 +0900 Subject: [PATCH] qualcommax: ipq807x: fix LEDs on Buffalo WXR-5950AX12 On Buffalo WXR-5590AX12, some LEDs don't have "function" property and only "color" property is available for the newer binding of LED on Linux Kernel. 2e659930d3 ("qualcommax: drop redundant label with new LED color/function format") removes "label" property from LEDs, then, multiple ":" (ex.: "white:"/"red:") will be appeared as LED names and renamed to ":_" ("ex.: "white:_1", "green:_2", ...) by kernel. logs: [ 5.372863] leds-gpio leds: Led white: renamed to white:_1 due to name collision [ 5.375796] leds-gpio leds: Led red: renamed to red:_1 due to name collision /sys/class/leds: root@OpenWrt:/# ls /sys/class/leds/ red: red:power white: white:power red:_1 red:wlan white:_1 white:wlan Fix this issue by adding missing "function" property to LEDs on Buffalo WXR-5950AX12. Note: there are no appropriate functions in dt-bindings/leds/common.h for some LEDs, so use the hardcoded strings for them instead. Fixes: 2e659930d3 ("qualcommax: drop redundant label with new LED color/function format") Signed-off-by: INAGAKI Hiroshi --- .../files/arch/arm64/boot/dts/qcom/ipq8074-wxr-5950ax12.dts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq8074-wxr-5950ax12.dts b/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq8074-wxr-5950ax12.dts index d6411e4fa5..d8237e81dd 100644 --- a/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq8074-wxr-5950ax12.dts +++ b/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq8074-wxr-5950ax12.dts @@ -33,11 +33,13 @@ led-0 { gpios = <&tlmm 21 GPIO_ACTIVE_HIGH>; color = ; + function = "router"; }; led-1 { gpios = <&tlmm 22 GPIO_ACTIVE_HIGH>; color = ; + function = "router"; }; led_power_red: led-2 { @@ -55,11 +57,13 @@ led-4 { gpios = <&tlmm 43 GPIO_ACTIVE_HIGH>; color = ; + function = "internet"; }; led-5 { gpios = <&tlmm 44 GPIO_ACTIVE_HIGH>; color = ; + function = "internet"; }; led-6 { -- 2.30.2