From f29627c2a3df5732af84bc217df26d1c311f5112 Mon Sep 17 00:00:00 2001 From: John Kacur Date: Tue, 15 Dec 2009 16:46:06 -0800 Subject: [PATCH] efirtc: explicitly set llseek to no_llseek Now that we've removed the BKL here, let's explicitly set llseek to no_llseek since the default llseek is not used here. The default_llseek function still contains the BKL. When we are auditing code to see if we can remove the BKL, this is one of the hidden considerations we need to take into account. i.e., is there syncronization between code that has the BKL and llseek. At the same time we remove the BKL it would be a good idea to do indicate when no llseek function is required, so we don't have to revisit this code again, when we are trying to determine if we can remove the BKL from the default_llseek. Signed-off-by: John Kacur Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- drivers/char/efirtc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/efirtc.c b/drivers/char/efirtc.c index 26a47dc88f61..53c524e7b829 100644 --- a/drivers/char/efirtc.c +++ b/drivers/char/efirtc.c @@ -285,6 +285,7 @@ static const struct file_operations efi_rtc_fops = { .unlocked_ioctl = efi_rtc_ioctl, .open = efi_rtc_open, .release = efi_rtc_close, + .llseek = no_llseek, }; static struct miscdevice efi_rtc_dev= { -- 2.30.2