From edda26dc4fff077017fb61d5d90dfb8212bb6195 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Rafa=C5=82=20Mi=C5=82ecki?= Date: Thu, 9 Mar 2017 11:03:06 +0100 Subject: [PATCH] bcm53xx: fix memory corruption caused by iproc PCE controller driver MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This is a simple revert of upstream patch for now. Signed-off-by: Rafał Miłecki --- ...-Request-host-bridge-window-resource.patch | 28 +++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 target/linux/bcm53xx/patches-4.9/800-Revert-PCI-iproc-Request-host-bridge-window-resource.patch diff --git a/target/linux/bcm53xx/patches-4.9/800-Revert-PCI-iproc-Request-host-bridge-window-resource.patch b/target/linux/bcm53xx/patches-4.9/800-Revert-PCI-iproc-Request-host-bridge-window-resource.patch new file mode 100644 index 0000000000..5c8fef76cf --- /dev/null +++ b/target/linux/bcm53xx/patches-4.9/800-Revert-PCI-iproc-Request-host-bridge-window-resource.patch @@ -0,0 +1,28 @@ +From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= +Date: Thu, 9 Mar 2017 10:53:06 +0100 +Subject: [PATCH] Revert "PCI: iproc: Request host bridge window resources" +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +This reverts commit c3245a566400 ("PCI: iproc: Request host bridge +window resources"). It was passing local variable of +iproc_pcie_bcma_probe to the devm_request_pci_bus_resources. It meant +using unallocated memory for tracing resource which could easily result +in corruption and crashes. + +Signed-off-by: Rafał Miłecki +--- + +--- a/drivers/pci/host/pcie-iproc.c ++++ b/drivers/pci/host/pcie-iproc.c +@@ -462,9 +462,6 @@ int iproc_pcie_setup(struct iproc_pcie * + struct pci_bus *bus; + + dev = pcie->dev; +- ret = devm_request_pci_bus_resources(dev, res); +- if (ret) +- return ret; + + ret = phy_init(pcie->phy); + if (ret) { -- 2.30.2