From ec58d2a8727d34a2b51295895d51279abf9edd74 Mon Sep 17 00:00:00 2001 From: Sudip Mukherjee Date: Fri, 4 Sep 2015 16:22:06 +0530 Subject: [PATCH] staging: most: style of bool comparison BOOLEAN tests do not need any comparison to TRUE or FALSE. Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman --- drivers/staging/most/hdm-usb/hdm_usb.c | 10 +++++----- drivers/staging/most/mostcore/core.c | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c index 34843b0b495b..9bbefaaa0134 100644 --- a/drivers/staging/most/hdm-usb/hdm_usb.c +++ b/drivers/staging/most/hdm-usb/hdm_usb.c @@ -308,7 +308,7 @@ static int hdm_poison_channel(struct most_interface *iface, int channel) mutex_lock(&mdev->io_mutex); free_anchored_buffers(mdev, channel); - if (mdev->padding_active[channel] == true) + if (mdev->padding_active[channel]) mdev->padding_active[channel] = false; if (mdev->conf[channel].data_type == MOST_CH_ASYNC) { @@ -411,7 +411,7 @@ static void hdm_write_completion(struct urb *urb) dev = &mdev->usb_device->dev; if ((urb->status == -ENOENT) || (urb->status == -ECONNRESET) || - (mdev->is_channel_healthy[channel] == false)) { + (!mdev->is_channel_healthy[channel])) { complete(&anchor->urb_compl); return; } @@ -576,7 +576,7 @@ static void hdm_read_completion(struct urb *urb) dev = &mdev->usb_device->dev; if ((urb->status == -ENOENT) || (urb->status == -ECONNRESET) || - (mdev->is_channel_healthy[channel] == false)) { + (!mdev->is_channel_healthy[channel])) { complete(&anchor->urb_compl); return; } @@ -605,7 +605,7 @@ static void hdm_read_completion(struct urb *urb) } } else { mbo->processed_length = urb->actual_length; - if (mdev->padding_active[channel] == false) { + if (!mdev->padding_active[channel]) { mbo->status = MBO_SUCCESS; } else { if (hdm_remove_padding(mdev, channel, mbo)) { @@ -685,7 +685,7 @@ static int hdm_enqueue(struct most_interface *iface, int channel, struct mbo *mb list_add_tail(&anchor->list, &mdev->anchor_list[channel]); spin_unlock_irqrestore(&mdev->anchor_list_lock[channel], flags); - if ((mdev->padding_active[channel] == true) && + if ((mdev->padding_active[channel]) && (conf->direction & MOST_CH_TX)) if (hdm_add_padding(mdev, channel, mbo)) { retval = -EIO; diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c index 87f950fad9b4..eb4e15938875 100644 --- a/drivers/staging/most/mostcore/core.c +++ b/drivers/staging/most/mostcore/core.c @@ -1339,7 +1339,7 @@ static void most_write_completion(struct mbo *mbo) c = mbo->context; if (mbo->status == MBO_E_INVAL) pr_info("WARN: Tx MBO status: invalid\n"); - if (unlikely((c->is_poisoned == true) || (mbo->status == MBO_E_CLOSE))) + if (unlikely(c->is_poisoned || (mbo->status == MBO_E_CLOSE))) trash_mbo(mbo); else arm_mbo(mbo); @@ -1444,7 +1444,7 @@ static void most_read_completion(struct mbo *mbo) struct most_c_obj *c; c = mbo->context; - if (unlikely((c->is_poisoned == true) || (mbo->status == MBO_E_CLOSE))) + if (unlikely(c->is_poisoned || (mbo->status == MBO_E_CLOSE))) goto release_mbo; if (mbo->status == MBO_E_INVAL) { -- 2.30.2