From e9e0d2877fb27b81c6b55b57fad684e3f15c15bf Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 27 Jan 2017 12:53:13 +0900 Subject: [PATCH] fiptool: simplify assert() for add_image(_desc) lookup_image(_desc)_from_uuid() traverses the linked list, so it is not efficient. We just want to make sure *p points to NULL here. Signed-off-by: Masahiro Yamada --- tools/fiptool/fiptool.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tools/fiptool/fiptool.c b/tools/fiptool/fiptool.c index b79c0d69..7a5c2cd7 100644 --- a/tools/fiptool/fiptool.c +++ b/tools/fiptool/fiptool.c @@ -202,11 +202,10 @@ static void add_image_desc(image_desc_t *desc) { image_desc_t **p = &image_desc_head; - assert(lookup_image_desc_from_uuid(&desc->uuid) == NULL); - while (*p) p = &(*p)->next; + assert(*p == NULL); *p = desc; nr_image_descs++; } @@ -244,11 +243,10 @@ static void add_image(image_t *image) { image_t **p = &image_head; - assert(lookup_image_from_uuid(&image->uuid) == NULL); - while (*p) p = &(*p)->next; + assert(*p == NULL); *p = image; nr_images++; -- 2.30.2