From dfc065f19fe0ce4ef7a52011801c5c19131e6529 Mon Sep 17 00:00:00 2001 From: Rupesh Gujare Date: Fri, 23 Aug 2013 16:11:01 +0100 Subject: [PATCH] staging: ozwpan: Fix wrong error check. schedule_work() returns true if succeeded & false on failure, error check was doing exactly reverse. Also removes extra variable. Signed-off-by: Rupesh Gujare Signed-off-by: Greg Kroah-Hartman --- drivers/staging/ozwpan/ozpd.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c index 5d24af3b4cd7..d39a3df4842b 100644 --- a/drivers/staging/ozwpan/ozpd.c +++ b/drivers/staging/ozwpan/ozpd.c @@ -261,17 +261,13 @@ void oz_pd_free(struct work_struct *work) */ void oz_pd_destroy(struct oz_pd *pd) { - int ret; - if (hrtimer_active(&pd->timeout)) hrtimer_cancel(&pd->timeout); if (hrtimer_active(&pd->heartbeat)) hrtimer_cancel(&pd->heartbeat); INIT_WORK(&pd->workitem, oz_pd_free); - ret = schedule_work(&pd->workitem); - - if (ret) + if (!schedule_work(&pd->workitem)) oz_pd_dbg(pd, ON, "failed to schedule workitem\n"); } -- 2.30.2