From dfa612e421cbe4c940e08aa467718fae81fd53db Mon Sep 17 00:00:00 2001 From: Jean Thomas Date: Tue, 5 Dec 2023 11:12:37 +0100 Subject: [PATCH] uqmi: improve response detection Create a helper which checks the flags depending on the service indicated in the received message, as the response flag is not the same for the CTL service and the other services. This avoids considering a CTL indication as a valid response. Also use a mask in order to check the flags, as they are a bitmap. Signed-off-by: Jean Thomas --- dev.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/dev.c b/dev.c index bd10207..2d1597c 100644 --- a/dev.c +++ b/dev.c @@ -62,6 +62,20 @@ qmi_get_service_idx(QmiService svc) return -1; } +static bool qmi_message_is_response(struct qmi_msg *msg) +{ + if (msg->qmux.service == QMI_SERVICE_CTL) { + if (msg->flags & QMI_CTL_FLAG_RESPONSE) + return true; + } + else { + if (msg->flags & QMI_SERVICE_FLAG_RESPONSE) + return true; + } + + return false; +} + static void __qmi_request_complete(struct qmi_dev *qmi, struct qmi_request *req, struct qmi_msg *msg) { void *tlv_buf; @@ -96,7 +110,7 @@ static void qmi_process_msg(struct qmi_dev *qmi, struct qmi_msg *msg) struct qmi_request *req; uint16_t tid; - if (msg->flags != QMI_CTL_FLAG_RESPONSE && msg->flags != QMI_SERVICE_FLAG_RESPONSE) + if (!qmi_message_is_response(msg)) return; if (msg->qmux.service == QMI_SERVICE_CTL) -- 2.30.2