From de467c116ca2ffc141d2abf8aef18b360fb19b21 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Thu, 20 Jun 2019 09:31:06 +0200 Subject: [PATCH] fjes: no need to check return value of debugfs_create functions When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: "David S. Miller" Cc: Yangtao Li Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: David S. Miller --- drivers/net/fjes/fjes_debugfs.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/fjes/fjes_debugfs.c b/drivers/net/fjes/fjes_debugfs.c index 153fc998f9c1..2c2095e7cf1e 100644 --- a/drivers/net/fjes/fjes_debugfs.c +++ b/drivers/net/fjes/fjes_debugfs.c @@ -52,20 +52,11 @@ DEFINE_SHOW_ATTRIBUTE(fjes_dbg_status); void fjes_dbg_adapter_init(struct fjes_adapter *adapter) { const char *name = dev_name(&adapter->plat_dev->dev); - struct dentry *pfile; adapter->dbg_adapter = debugfs_create_dir(name, fjes_debug_root); - if (!adapter->dbg_adapter) { - dev_err(&adapter->plat_dev->dev, - "debugfs entry for %s failed\n", name); - return; - } - pfile = debugfs_create_file("status", 0444, adapter->dbg_adapter, - adapter, &fjes_dbg_status_fops); - if (!pfile) - dev_err(&adapter->plat_dev->dev, - "debugfs status for %s failed\n", name); + debugfs_create_file("status", 0444, adapter->dbg_adapter, adapter, + &fjes_dbg_status_fops); } void fjes_dbg_adapter_exit(struct fjes_adapter *adapter) @@ -77,8 +68,6 @@ void fjes_dbg_adapter_exit(struct fjes_adapter *adapter) void fjes_dbg_init(void) { fjes_debug_root = debugfs_create_dir(fjes_driver_name, NULL); - if (!fjes_debug_root) - pr_info("init of debugfs failed\n"); } void fjes_dbg_exit(void) -- 2.30.2