From bf30ad1408f91d579f344e7798a2f03754fd21fc Mon Sep 17 00:00:00 2001 From: Christian Lamparter Date: Thu, 23 Sep 2021 18:37:38 +0200 Subject: [PATCH] apm821xx: MBL: band-aid MBL DUO Takimata reported on the OpenWrt forum in thread [0], that his MyBook Live Duo wasn't booting OpenWrt 21.02 after upgrading from the previous OpenWrt 19.07. The last logged entries on his console |[ 0.531599] sata1-regulator GPIO handle specifies active low - ignored |[ 0.538391] sata0-regulator GPIO handle specifies active low - ignored |[ 0.759791] ata2: SATA link down (SStatus 0 SControl 300) |[ 0.765251] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300) |[ 5.909555] ata1.00: qc timeout (cmd 0xec) |[ 5.913656] ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4) |[ 6.231757] ata1: SATA link down (SStatus 0 SControl 300) This extract clearly showed that the HDD on which OpenWrt is installed, simply disappeared after the SATA power regulators had been initialized. Since the device-tree regulators haven't changed since the OpenWrt 19.07 days this will require further investigation on the snapshot/master/trunk branch. For the time being, it was requested to just delete the nodes so, the device will boot again. Which unfortunately, will have to wait until 21.02.1 is released. He also confirmed that the My Book Live Single wasn't affected. It works with or without this change. [0] Reported-by: Takimata (forum.openwrt.org/u/takimata) Signed-off-by: Christian Lamparter --- target/linux/apm821xx/dts/wd-mybooklive.dts | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/target/linux/apm821xx/dts/wd-mybooklive.dts b/target/linux/apm821xx/dts/wd-mybooklive.dts index 3fd636cb237..895d914d6b9 100644 --- a/target/linux/apm821xx/dts/wd-mybooklive.dts +++ b/target/linux/apm821xx/dts/wd-mybooklive.dts @@ -123,24 +123,6 @@ regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; }; - - sata1pwr: sata1-regulator { - compatible = "regulator-fixed"; - regulator-name = "Power Drive Port 1"; - gpios = <&GPIO1 3 GPIO_ACTIVE_LOW>; - regulator-min-microvolt = <12000000>; - regulator-max-microvolt = <12000000>; - regulator-always-on; /* needed to read OS from HDD */ - }; - - sata0pwr: sata0-regulator { - compatible = "regulator-fixed"; - regulator-name = "Power Drive Port 0"; - gpios = <&GPIO1 7 GPIO_ACTIVE_LOW>; - regulator-min-microvolt = <12000000>; - regulator-max-microvolt = <12000000>; - regulator-always-on; /* needed to read OS from HDD */ - }; }; &EMAC0 { -- 2.30.2