From bdd9dd8ab2859d589c63c2db462674b0e0535b46 Mon Sep 17 00:00:00 2001 From: Adrian Schmutzler Date: Fri, 25 Sep 2020 21:10:41 +0200 Subject: [PATCH] ipq40xx: tidy up dts-v1 statements The "/dts-v1/;" identifier is supposed to be present once at the top of a device tree file after the includes have been processed. Therefore, adding it to a DTS _and_ a DTSI file is actually wrong, as it will be present twice then (though the compiler does not complain about it). In ipq40xx, the dts-v1 statement is already included in qcom-ipq4019.dtsi, so we don't have to add it anywhere at all. However, based on the conditions stated above, this requires qcom-ipq4019.dtsi to be included as the first file in any DTS(I). Consequently, this patch removes all cases of dts-v1 for the ipq40xx target, and moves the includes accordingly where necessary. While at it, remove a few obviously unneeded includes on the way. Signed-off-by: Adrian Schmutzler --- .../ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-ex6100v2.dts | 2 -- .../ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-ex6150v2.dts | 2 -- .../files/arch/arm/boot/dts/qcom-ipq4018-wrtq-329acn.dts | 4 +--- .../ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-ea8300.dts | 2 -- .../files/arch/arm/boot/dts/qcom-ipq4019-map-ac2200.dts | 1 - .../ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-mr8300.dts | 2 -- .../files/arch/arm/boot/dts/qcom-ipq4019-u4019-32m.dts | 2 -- .../ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-xx8300.dtsi | 2 -- 8 files changed, 1 insertion(+), 16 deletions(-) diff --git a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-ex6100v2.dts b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-ex6100v2.dts index 2b93dcbb99e..1495c64da95 100644 --- a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-ex6100v2.dts +++ b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-ex6100v2.dts @@ -16,8 +16,6 @@ */ #include "qcom-ipq4018-ex61x0v2.dtsi" -#include -#include / { model = "Netgear EX6100v2"; diff --git a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-ex6150v2.dts b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-ex6150v2.dts index f1c44c1ae8b..ce24466e548 100644 --- a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-ex6150v2.dts +++ b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-ex6150v2.dts @@ -16,8 +16,6 @@ */ #include "qcom-ipq4018-ex61x0v2.dtsi" -#include -#include / { model = "Netgear EX6150v2"; diff --git a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-wrtq-329acn.dts b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-wrtq-329acn.dts index faac71489c0..2465348a821 100644 --- a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-wrtq-329acn.dts +++ b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-wrtq-329acn.dts @@ -1,12 +1,10 @@ // SPDX-License-Identifier: GPL-2.0-or-later OR MIT -/dts-v1/; +#include "qcom-ipq4019.dtsi" #include #include #include -#include "qcom-ipq4019.dtsi" - / { model = "Luma Home WRTQ-329ACN"; compatible = "luma,wrtq-329acn"; diff --git a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-ea8300.dts b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-ea8300.dts index 9c1e0f04bbe..d8acf36c4a5 100644 --- a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-ea8300.dts +++ b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-ea8300.dts @@ -1,7 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-or-later OR MIT -/dts-v1/; - #include "qcom-ipq4019-xx8300.dtsi" / { diff --git a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-map-ac2200.dts b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-map-ac2200.dts index 06d0277b016..92aaa927e2a 100644 --- a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-map-ac2200.dts +++ b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-map-ac2200.dts @@ -1,5 +1,4 @@ // SPDX-License-Identifier: GPL-2.0-or-later OR MIT -/dts-v1/; #include "qcom-ipq4019.dtsi" #include diff --git a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-mr8300.dts b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-mr8300.dts index 4818a2df598..a09730a9e88 100644 --- a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-mr8300.dts +++ b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-mr8300.dts @@ -1,7 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-or-later OR MIT -/dts-v1/; - #include "qcom-ipq4019-xx8300.dtsi" / { diff --git a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-u4019-32m.dts b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-u4019-32m.dts index 63fbfb65c17..811c82b9c53 100644 --- a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-u4019-32m.dts +++ b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-u4019-32m.dts @@ -1,7 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-or-later OR MIT -/dts-v1/; - #include "qcom-ipq4019-u4019.dtsi" #include #include diff --git a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-xx8300.dtsi b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-xx8300.dtsi index 77d495e670f..8f971e505c3 100644 --- a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-xx8300.dtsi +++ b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-xx8300.dtsi @@ -8,8 +8,6 @@ * */ -/dts-v1/; - #include "qcom-ipq4019.dtsi" #include #include -- 2.30.2