From badfa5be854d52956eb32aa3b8d29db3fd2b05a7 Mon Sep 17 00:00:00 2001 From: Daniel Vetter Date: Mon, 28 Jan 2019 18:22:58 +0100 Subject: [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested Compared to the RFC[1] no changes to the patch itself, but igt moved forward a lot: - gitlab CI builds with: reduced configs/libraries, arm cross build and a sysroot build (should address all the build/cross platform concerns raised in the RFC discussions). - tests reorganized into subdirectories so that the i915-gem tests don't clog the main/shared tests directory anymore - quite a few more non-intel people contributing/reviewing/committing igt tests patches. I think this addresses all the concerns raised in the RFC discussions, and assuming there's enough Acks and no new issues that pop up, we can go ahead with this. v2: - Use "should" (in the usual RFC sense) to make it clear that in the end this is all up to reviewer's discretion, as usual (Jani). - Also in the title s/mandatory/strongly suggested/ (me) - Make it clear we're not going to block features if a testcase is not feasible, given hw and state of igt, both having some good gaps in what can be tested (Harry, Eric, Sean, ...). 1: https://patchwork.kernel.org/patch/10648851/ Cc: Petri Latvala Cc: Arkadiusz Hiler Cc: Liviu Dudau Cc: Sean Paul Cc: Eric Anholt Cc: Alex Deucher Cc: Dave Airlie Cc: Daniel Stone Cc: "Wentland, Harry" Cc: Brian Starkey Reviewed-by: Eric Anholt (v1) Acked-by: Petri Latvala Acked-by: Arkadiusz Hiler Acked-by: Sean Paul Acked-by: "Wentland, Harry" Signed-off-by: Daniel Vetter Acked-by: Liviu Dudau Acked-by: Jani Nikula Acked-by: Brian Starkey Acked-by: Tomi Valkeinen Acked-by: Boris Brezillon Acked-by: Alex Deucher Acked-by: Dave Airlie Link: https://patchwork.freedesktop.org/patch/msgid/20190128172258.9585-1-daniel.vetter@ffwll.ch --- Documentation/gpu/drm-uapi.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst index a752aa561ea4..c9fd23efd957 100644 --- a/Documentation/gpu/drm-uapi.rst +++ b/Documentation/gpu/drm-uapi.rst @@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the slightly unintuitive meaning of Testing and validation ====================== +Testing Requirements for userspace API +-------------------------------------- + +New cross-driver userspace interface extensions, like new IOCTL, new KMS +properties, new files in sysfs or anything else that constitutes an API change +should have driver-agnostic testcases in IGT for that feature, if such a test +can be reasonably made using IGT for the target hardware. + Validating changes with IGT --------------------------- -- 2.30.2