From b2aca5a263e73cb2def1c6cbb36f3be24d38089b Mon Sep 17 00:00:00 2001 From: Christian Lamparter Date: Sat, 11 Dec 2021 00:09:13 +0100 Subject: [PATCH] ath79: fix various dts warnings ar9344_openmesh_mr600-v1.dts:40.10-44.5: Warning (gpios_property): /leds-ath9k/wifi2g: Missing property '#gpio-cells' in node /ahb/pcie-controller@180c0000/wifi@0,0 or bad phandle => added gpio-controller + #gpio-cells qca955x_zyxel_nbg6x16.dtsi:121.3-13: Warning (reg_format): /ahb/usb@1b000000/port@1:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) ../dts/qca955x_zyxel_nbg6x16.dtsi:131.3-13: Warning (reg_format): /ahb/usb@1b400000/port@1:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) qca955x_zyxel_nbg6x16.dtsi:120.20-123.4: Warning (avoid_default_addr_size): /ahb/usb@1b000000/port@1: Relying on default #address-cells value => ath79's usb-nodes are missing the address- and size-cells properties. These are needed for usb led trigger support. ar7242_ubnt_sw.dtsi:54.4-14: Warning (reg_format): /gpio_spi/gpio_spi@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) => the #address-cells and #size-cells had to be nudged. qca9531_dlink_dch-g020-a1.dts:19.6-39.4: Warning (i2c_bus_bridge): /i2c: incorrect #size-cells for I2C bus => #size-cells = <0>; Signed-off-by: Christian Lamparter --- target/linux/ath79/dts/ar7100.dtsi | 6 ++++++ target/linux/ath79/dts/ar7240.dtsi | 3 +++ target/linux/ath79/dts/ar7241.dtsi | 3 +++ target/linux/ath79/dts/ar7242.dtsi | 3 +++ target/linux/ath79/dts/ar7242_ubnt_edgeswitch-8xp.dts | 5 +++-- target/linux/ath79/dts/ar7242_ubnt_sw.dtsi | 4 ++-- target/linux/ath79/dts/ar9330.dtsi | 3 +++ target/linux/ath79/dts/ar9344_openmesh_mr600.dtsi | 3 +++ target/linux/ath79/dts/ar934x.dtsi | 3 +++ target/linux/ath79/dts/qca9531_dlink_dch-g020-a1.dts | 2 +- target/linux/ath79/dts/qca953x.dtsi | 3 +++ target/linux/ath79/dts/qca955x.dtsi | 6 ++++++ target/linux/ath79/dts/qca956x.dtsi | 6 ++++++ 13 files changed, 45 insertions(+), 5 deletions(-) diff --git a/target/linux/ath79/dts/ar7100.dtsi b/target/linux/ath79/dts/ar7100.dtsi index 86673cb5da3..12ab7e50394 100644 --- a/target/linux/ath79/dts/ar7100.dtsi +++ b/target/linux/ath79/dts/ar7100.dtsi @@ -146,6 +146,9 @@ has-synopsys-hc-bug; status = "disabled"; + + #address-cells = <1>; + #size-cells = <0>; }; usb1: usb@1c000000 { @@ -159,6 +162,9 @@ phys = <&usb_phy>; status = "disabled"; + + #address-cells = <1>; + #size-cells = <0>; }; spi: spi@1f000000 { diff --git a/target/linux/ath79/dts/ar7240.dtsi b/target/linux/ath79/dts/ar7240.dtsi index 730c509d7bd..425d75f0d7c 100644 --- a/target/linux/ath79/dts/ar7240.dtsi +++ b/target/linux/ath79/dts/ar7240.dtsi @@ -29,6 +29,9 @@ phys = <&usb_phy>; status = "disabled"; + + #address-cells = <1>; + #size-cells = <0>; }; }; diff --git a/target/linux/ath79/dts/ar7241.dtsi b/target/linux/ath79/dts/ar7241.dtsi index 4044cdee0e7..ff7a61f9214 100644 --- a/target/linux/ath79/dts/ar7241.dtsi +++ b/target/linux/ath79/dts/ar7241.dtsi @@ -36,6 +36,9 @@ phys = <&usb_phy>; status = "disabled"; + + #address-cells = <1>; + #size-cells = <0>; }; }; diff --git a/target/linux/ath79/dts/ar7242.dtsi b/target/linux/ath79/dts/ar7242.dtsi index be28ae78385..eda1b16309e 100644 --- a/target/linux/ath79/dts/ar7242.dtsi +++ b/target/linux/ath79/dts/ar7242.dtsi @@ -36,6 +36,9 @@ phys = <&usb_phy>; status = "disabled"; + + #address-cells = <1>; + #size-cells = <0>; }; }; diff --git a/target/linux/ath79/dts/ar7242_ubnt_edgeswitch-8xp.dts b/target/linux/ath79/dts/ar7242_ubnt_edgeswitch-8xp.dts index f5433a30a3d..0c2fe394d45 100644 --- a/target/linux/ath79/dts/ar7242_ubnt_edgeswitch-8xp.dts +++ b/target/linux/ath79/dts/ar7242_ubnt_edgeswitch-8xp.dts @@ -114,11 +114,12 @@ ethernet-switch@1e { compatible = "brcm,bcm53128"; - #address-cells = <1>; - #size-cells = <0>; reg = <0x1e>; ports { + #address-cells = <1>; + #size-cells = <0>; + port0@0 { reg = <0>; label = "lan1"; diff --git a/target/linux/ath79/dts/ar7242_ubnt_sw.dtsi b/target/linux/ath79/dts/ar7242_ubnt_sw.dtsi index 3f996a16c75..c776c8ef6e7 100644 --- a/target/linux/ath79/dts/ar7242_ubnt_sw.dtsi +++ b/target/linux/ath79/dts/ar7242_ubnt_sw.dtsi @@ -41,8 +41,8 @@ gpio_spi { compatible = "spi-gpio"; - #address-cells = <0x1>; - ranges; + #address-cells = <1>; + #size-cells = <0>; sck-gpios = <&gpio 16 GPIO_ACTIVE_HIGH>; mosi-gpios = <&gpio 15 GPIO_ACTIVE_HIGH>; diff --git a/target/linux/ath79/dts/ar9330.dtsi b/target/linux/ath79/dts/ar9330.dtsi index 06e1cf4601d..aed8e205ada 100644 --- a/target/linux/ath79/dts/ar9330.dtsi +++ b/target/linux/ath79/dts/ar9330.dtsi @@ -116,6 +116,9 @@ phys = <&usb_phy>; status = "disabled"; + + #address-cells = <1>; + #size-cells = <0>; }; spi: spi@1f000000 { diff --git a/target/linux/ath79/dts/ar9344_openmesh_mr600.dtsi b/target/linux/ath79/dts/ar9344_openmesh_mr600.dtsi index de8bfb70b74..bbbcc3e0b66 100644 --- a/target/linux/ath79/dts/ar9344_openmesh_mr600.dtsi +++ b/target/linux/ath79/dts/ar9344_openmesh_mr600.dtsi @@ -129,6 +129,9 @@ nvmem-cells = <&macaddr_art_0>; nvmem-cell-names = "mac-address"; mac-address-increment = <8>; + + gpio-controller; + #gpio-cells = <2>; }; }; diff --git a/target/linux/ath79/dts/ar934x.dtsi b/target/linux/ath79/dts/ar934x.dtsi index 84dbe65f855..d88c7bfabc1 100644 --- a/target/linux/ath79/dts/ar934x.dtsi +++ b/target/linux/ath79/dts/ar934x.dtsi @@ -175,6 +175,9 @@ phys = <&usb_phy>; status = "disabled"; + + #address-cells = <1>; + #size-cells = <0>; }; nand: nand@1b000200 { diff --git a/target/linux/ath79/dts/qca9531_dlink_dch-g020-a1.dts b/target/linux/ath79/dts/qca9531_dlink_dch-g020-a1.dts index d2fbc09c60f..9a4db6f9fcd 100644 --- a/target/linux/ath79/dts/qca9531_dlink_dch-g020-a1.dts +++ b/target/linux/ath79/dts/qca9531_dlink_dch-g020-a1.dts @@ -19,7 +19,7 @@ i2c { compatible = "i2c-gpio"; #address-cells = <1>; - #size-cells = <1>; + #size-cells = <0>; sda-gpios = <&gpio 0 GPIO_ACTIVE_HIGH>; scl-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>; diff --git a/target/linux/ath79/dts/qca953x.dtsi b/target/linux/ath79/dts/qca953x.dtsi index d73163c3fe8..6df0941eefc 100644 --- a/target/linux/ath79/dts/qca953x.dtsi +++ b/target/linux/ath79/dts/qca953x.dtsi @@ -201,6 +201,9 @@ phys = <&usb_phy>; status = "disabled"; + + #address-cells = <1>; + #size-cells = <0>; }; spi: spi@1f000000 { diff --git a/target/linux/ath79/dts/qca955x.dtsi b/target/linux/ath79/dts/qca955x.dtsi index 8138f4afee6..fb820169d54 100644 --- a/target/linux/ath79/dts/qca955x.dtsi +++ b/target/linux/ath79/dts/qca955x.dtsi @@ -265,6 +265,9 @@ phys = <&usb_phy0>; status = "disabled"; + + #address-cells = <1>; + #size-cells = <0>; }; usb1: usb@1b400000 { @@ -283,6 +286,9 @@ phys = <&usb_phy1>; status = "disabled"; + + #address-cells = <1>; + #size-cells = <0>; }; nand: nand@1b800200 { diff --git a/target/linux/ath79/dts/qca956x.dtsi b/target/linux/ath79/dts/qca956x.dtsi index 8627f7ee40b..f2452e9dc7e 100644 --- a/target/linux/ath79/dts/qca956x.dtsi +++ b/target/linux/ath79/dts/qca956x.dtsi @@ -200,6 +200,9 @@ phys = <&usb_phy0>; status = "disabled"; + + #address-cells = <1>; + #size-cells = <0>; }; usb1: usb@1b400000 { @@ -219,6 +222,9 @@ phys = <&usb_phy1>; status = "disabled"; + + #address-cells = <1>; + #size-cells = <0>; }; spi: spi@1f000000 { -- 2.30.2