From ac56dc057d0a5dc0c9e014f6824bd63273eebe6e Mon Sep 17 00:00:00 2001 From: Jo-Philipp Wich Date: Wed, 21 Aug 2019 17:59:58 +0200 Subject: [PATCH] luci-base: form.js: use createHandlerFn() for modal button actions Signed-off-by: Jo-Philipp Wich --- .../htdocs/luci-static/resources/form.js | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/modules/luci-base/htdocs/luci-static/resources/form.js b/modules/luci-base/htdocs/luci-static/resources/form.js index 2d1d6960ba..31f6bd9616 100644 --- a/modules/luci-base/htdocs/luci-static/resources/form.js +++ b/modules/luci-base/htdocs/luci-static/resources/form.js @@ -1153,24 +1153,18 @@ var CBITableSection = CBITypedSection.extend({ } } - //ev.target.classList.add('spinning'); Promise.resolve(this.addModalOptions(s, section_id, ev)).then(L.bind(m.render, m)).then(L.bind(function(nodes) { - //ev.target.classList.remove('spinning'); L.ui.showModal(title, [ nodes, E('div', { 'class': 'right' }, [ - E('input', { - 'type': 'button', + E('button', { 'class': 'btn', - 'click': L.bind(this.handleModalCancel, this, m), - 'value': _('Dismiss') - }), ' ', - E('input', { - 'type': 'button', + 'click': L.ui.createHandlerFn(this, 'handleModalCancel', m) + }, _('Dismiss')), ' ', + E('button', { 'class': 'cbi-button cbi-button-positive important', - 'click': L.bind(this.handleModalSave, this, m), - 'value': _('Save') - }) + 'click': L.ui.createHandlerFn(this, 'handleModalSave', m) + }, _('Save')) ]) ], 'cbi-modal'); }, this)).catch(L.error); -- 2.30.2