From 9ca81646b9235f8963c5264f15597a9b61c029d4 Mon Sep 17 00:00:00 2001 From: Sven Eckelmann Date: Mon, 19 Mar 2018 14:52:38 +0100 Subject: [PATCH] ipq40xx: Use constant to set gpio active low/high The GPIO configuration in the DTS have as third parameter the active low/high configuration. This parameter is not easy to parse by humans when it is only set to 0/1. It is better to use the predefined constants GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW. Signed-off-by: Sven Eckelmann --- .../ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-a42.dts | 2 +- .../files-4.14/arch/arm/boot/dts/qcom-ipq4018-rt-ac58u.dts | 4 ++-- .../files-4.14/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi | 3 ++- .../files-4.14/arch/arm/boot/dts/qcom-ipq4019-fritz4040.dts | 2 +- .../files-4.14/arch/arm/boot/dts/qcom-ipq4028-wpj428.dts | 2 +- .../files-4.14/arch/arm/boot/dts/qcom-ipq4029-gl-b1300.dts | 2 +- .../files-4.14/arch/arm/boot/dts/qcom-ipq4029-mr33.dts | 2 +- 7 files changed, 9 insertions(+), 8 deletions(-) diff --git a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-a42.dts b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-a42.dts index 1ccd9f91c55d..222d39b7f663 100644 --- a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-a42.dts +++ b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-a42.dts @@ -190,7 +190,7 @@ pinctrl-0 = <&spi_0_pins>; pinctrl-names = "default"; status = "okay"; - cs-gpios = <&tlmm 54 0>; + cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>; m25p80@0 { #address-cells = <1>; diff --git a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-rt-ac58u.dts b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-rt-ac58u.dts index 2b40b9e171ec..446da0451b10 100644 --- a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-rt-ac58u.dts +++ b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4018-rt-ac58u.dts @@ -216,8 +216,8 @@ pinctrl-0 = <&spi_0_pins>; pinctrl-names = "default"; status = "okay"; - cs-gpios = <&tlmm 54 0>, - <&tlmm 59 0>; + cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>, + <&tlmm 59 GPIO_ACTIVE_HIGH>; m25p80@0 { #address-cells = <1>; diff --git a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi index 753adf937348..eeadc075dd56 100644 --- a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi +++ b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi @@ -15,6 +15,7 @@ */ #include "qcom-ipq4019.dtsi" +#include / { model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK04.1"; @@ -101,7 +102,7 @@ pinctrl-0 = <&spi_0_pins>; pinctrl-names = "default"; status = "okay"; - cs-gpios = <&tlmm 12 0>; + cs-gpios = <&tlmm 12 GPIO_ACTIVE_HIGH>; mx25l25635e@0 { #address-cells = <1>; diff --git a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-fritz4040.dts b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-fritz4040.dts index 65e802b2b2bc..4b5cbcac33b7 100644 --- a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-fritz4040.dts +++ b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4019-fritz4040.dts @@ -225,7 +225,7 @@ pinctrl-0 = <&spi_0_pins>; pinctrl-names = "default"; status = "okay"; - cs-gpios = <&tlmm 54 0>; + cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>; mx25l25635f@0 { compatible = "jedec,spi-nor"; diff --git a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4028-wpj428.dts b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4028-wpj428.dts index 746b289e3b4b..f9f0f96ae9c9 100644 --- a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4028-wpj428.dts +++ b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4028-wpj428.dts @@ -167,7 +167,7 @@ pinctrl-0 = <&spi_0_pins>; pinctrl-names = "default"; status = "okay"; - cs-gpios = <&tlmm 54 0>; + cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>; m25p80@0 { #address-cells = <1>; diff --git a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-gl-b1300.dts b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-gl-b1300.dts index f3db47fb75bf..c4b002bdd67b 100644 --- a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-gl-b1300.dts +++ b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-gl-b1300.dts @@ -193,7 +193,7 @@ pinctrl-0 = <&spi_0_pins>; pinctrl-names = "default"; status = "okay"; - cs-gpios = <&tlmm 54 0>; + cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>; mx25l25635f@0 { compatible = "jedec,spi-nor"; diff --git a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-mr33.dts b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-mr33.dts index 9c1ef4f020e7..ef6230126f47 100644 --- a/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-mr33.dts +++ b/target/linux/ipq40xx/files-4.14/arch/arm/boot/dts/qcom-ipq4029-mr33.dts @@ -60,7 +60,7 @@ status = "okay"; pinctrl-0 = <&mdio_pins>; pinctrl-names = "default"; - phy-reset-gpio = <&tlmm 47 0>; + phy-reset-gpio = <&tlmm 47 GPIO_ACTIVE_HIGH>; /delete-node/ ethernet-phy@0; /delete-node/ ethernet-phy@2; /delete-node/ ethernet-phy@3; -- 2.30.2