From 8eab0a003629d0b60563df5f9eaa973969bbc763 Mon Sep 17 00:00:00 2001 From: Henrique de Moraes Holschuh Date: Fri, 1 Nov 2019 08:56:50 -0300 Subject: [PATCH] busybox: disable default config option FEATURE_SUID=y MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Commit ad7c6102f209 ("busybox: fix missing install with suid bit set if FEATURE_SUID=y") actually fixes BUSYBOX_CONFIG_FEATURE_SUID option and thus would install busybox setuid root by default which would result in possibly unwanted change of current behaviour, so let's disable this option by default in order to preserve the current status-quo. For the record: disabling FEATURE_SUID to preserve the status-quo does *not* imply the current status-quo is "safer", or for that matter, in any way desireable. That is a discussion to be had on the mailing lists. Switching the FEATURE_SUID default to "n" is simply a compromise to facilitate the merge of the changes that unbreak FEATURE_SUID. Ref: PR#2502 Signed-off-by: Henrique de Moraes Holschuh [commit title/description facelift] Signed-off-by: Petr Å tetiar --- package/utils/busybox/Config-defaults.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/utils/busybox/Config-defaults.in b/package/utils/busybox/Config-defaults.in index 37238f05c3..c0aaecbb30 100644 --- a/package/utils/busybox/Config-defaults.in +++ b/package/utils/busybox/Config-defaults.in @@ -60,7 +60,7 @@ config BUSYBOX_DEFAULT_INSTALL_NO_USR default n config BUSYBOX_DEFAULT_FEATURE_SUID bool - default y + default n config BUSYBOX_DEFAULT_FEATURE_SUID_CONFIG bool default n -- 2.30.2