From 89390a9e5050054ff42dffb50abf2db427687e52 Mon Sep 17 00:00:00 2001
From: =?utf8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= <noltari@gmail.com>
Date: Thu, 9 Mar 2023 18:54:59 +0100
Subject: [PATCH] bmips: dts: fix warnings
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

- Add missing interrupt-parent to ext_intc.
- Add missing #address-cells and #size-cells to gpio_cntl.
- Use proper gpio handle for gpios (ar-5315u).

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
 target/linux/bmips/dts/bcm6318-comtrend-ar-5315u.dts | 4 ++--
 target/linux/bmips/dts/bcm6318.dtsi                  | 3 +++
 target/linux/bmips/dts/bcm63268.dtsi                 | 3 +++
 target/linux/bmips/dts/bcm6328.dtsi                  | 3 +++
 target/linux/bmips/dts/bcm6358.dtsi                  | 4 ++++
 target/linux/bmips/dts/bcm6362.dtsi                  | 3 +++
 target/linux/bmips/dts/bcm6368.dtsi                  | 4 ++++
 7 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/target/linux/bmips/dts/bcm6318-comtrend-ar-5315u.dts b/target/linux/bmips/dts/bcm6318-comtrend-ar-5315u.dts
index a54d63277054..ec50c3e07df5 100644
--- a/target/linux/bmips/dts/bcm6318-comtrend-ar-5315u.dts
+++ b/target/linux/bmips/dts/bcm6318-comtrend-ar-5315u.dts
@@ -23,14 +23,14 @@
 
 		wps {
 			label = "wps";
-			gpios = <&pinctrl 3 GPIO_ACTIVE_LOW>;
+			gpios = <&gpio 3 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_WPS_BUTTON>;
 			debounce-interval = <60>;
 		};
 
 		reset {
 			label = "reset";
-			gpios = <&pinctrl 33 GPIO_ACTIVE_LOW>;
+			gpios = <&gpio 33 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_RESTART>;
 			debounce-interval = <60>;
 		};
diff --git a/target/linux/bmips/dts/bcm6318.dtsi b/target/linux/bmips/dts/bcm6318.dtsi
index 13e1bf114419..eb012fe243be 100644
--- a/target/linux/bmips/dts/bcm6318.dtsi
+++ b/target/linux/bmips/dts/bcm6318.dtsi
@@ -103,6 +103,7 @@
 			interrupt-controller;
 			#interrupt-cells = <2>;
 
+			interrupt-parent = <&periph_intc>;
 			interrupts = <BCM6318_IRQ_EXT0>,
 				     <BCM6318_IRQ_EXT1>,
 				     <BCM6318_IRQ_EXT2>,
@@ -143,6 +144,8 @@
 		};
 
 		gpio_cntl: syscon@10000080 {
+			#address-cells = <1>;
+			#size-cells = <1>;
 			compatible = "brcm,bcm6318-gpio-sysctl",
 				     "syscon", "simple-mfd";
 			reg = <0x10000080 0x80>;
diff --git a/target/linux/bmips/dts/bcm63268.dtsi b/target/linux/bmips/dts/bcm63268.dtsi
index 2bc86d26f97e..248e1afc79bb 100644
--- a/target/linux/bmips/dts/bcm63268.dtsi
+++ b/target/linux/bmips/dts/bcm63268.dtsi
@@ -118,6 +118,7 @@
 			interrupt-controller;
 			#interrupt-cells = <2>;
 
+			interrupt-parent = <&periph_intc>;
 			interrupts = <BCM63268_IRQ_EXT0>,
 				     <BCM63268_IRQ_EXT1>,
 				     <BCM63268_IRQ_EXT2>,
@@ -154,6 +155,8 @@
 		};
 
 		gpio_cntl: syscon@100000c0 {
+			#address-cells = <1>;
+			#size-cells = <1>;
 			compatible = "brcm,bcm63268-gpio-sysctl",
 				     "syscon", "simple-mfd";
 			reg = <0x100000c0 0x80>;
diff --git a/target/linux/bmips/dts/bcm6328.dtsi b/target/linux/bmips/dts/bcm6328.dtsi
index dfd603b7c6ea..d61903e15480 100644
--- a/target/linux/bmips/dts/bcm6328.dtsi
+++ b/target/linux/bmips/dts/bcm6328.dtsi
@@ -105,6 +105,7 @@
 			interrupt-controller;
 			#interrupt-cells = <2>;
 
+			interrupt-parent = <&periph_intc>;
 			interrupts = <BCM6328_IRQ_EXTO>,
 				     <BCM6328_IRQ_EXT1>,
 				     <BCM6328_IRQ_EXT2>,
@@ -146,6 +147,8 @@
 		};
 
 		gpio_cntl: syscon@10000080 {
+			#address-cells = <1>;
+			#size-cells = <1>;
 			compatible = "brcm,bcm6328-gpio-sysctl",
 				     "syscon", "simple-mfd";
 			reg = <0x10000080 0x80>;
diff --git a/target/linux/bmips/dts/bcm6358.dtsi b/target/linux/bmips/dts/bcm6358.dtsi
index 34334df9ba1f..e08ead0623fd 100644
--- a/target/linux/bmips/dts/bcm6358.dtsi
+++ b/target/linux/bmips/dts/bcm6358.dtsi
@@ -124,6 +124,7 @@
 			interrupt-controller;
 			#interrupt-cells = <2>;
 
+			interrupt-parent = <&periph_intc>;
 			interrupts = <BCM6358_IRQ_EXT0>,
 				     <BCM6358_IRQ_EXT1>,
 				     <BCM6358_IRQ_EXT2>,
@@ -138,6 +139,7 @@
 			interrupt-controller;
 			#interrupt-cells = <2>;
 
+			interrupt-parent = <&periph_intc>;
 			interrupts = <BCM6358_IRQ_EXT4>,
 				     <BCM6358_IRQ_EXT5>;
 		};
@@ -158,6 +160,8 @@
 		};
 
 		gpio_cntl: syscon@fffe0080 {
+			#address-cells = <1>;
+			#size-cells = <1>;
 			compatible = "brcm,bcm6358-gpio-sysctl",
 				     "syscon", "simple-mfd";
 			reg = <0xfffe0080 0x50>;
diff --git a/target/linux/bmips/dts/bcm6362.dtsi b/target/linux/bmips/dts/bcm6362.dtsi
index d66a602df7a8..720afde7cf7b 100644
--- a/target/linux/bmips/dts/bcm6362.dtsi
+++ b/target/linux/bmips/dts/bcm6362.dtsi
@@ -118,6 +118,7 @@
 			interrupt-controller;
 			#interrupt-cells = <2>;
 
+			interrupt-parent = <&periph_intc>;
 			interrupts = <BCM6362_IRQ_EXT0>,
 				     <BCM6362_IRQ_EXT1>,
 				     <BCM6362_IRQ_EXT2>,
@@ -147,6 +148,8 @@
 		};
 
 		gpio_cntl: syscon@10000080 {
+			#address-cells = <1>;
+			#size-cells = <1>;
 			compatible = "brcm,bcm6362-gpio-sysctl",
 				     "syscon", "simple-mfd";
 			reg = <0x10000080 0x80>;
diff --git a/target/linux/bmips/dts/bcm6368.dtsi b/target/linux/bmips/dts/bcm6368.dtsi
index 5ba909219363..2eafa027cda9 100644
--- a/target/linux/bmips/dts/bcm6368.dtsi
+++ b/target/linux/bmips/dts/bcm6368.dtsi
@@ -108,6 +108,7 @@
 			interrupt-controller;
 			#interrupt-cells = <2>;
 
+			interrupt-parent = <&periph_intc>;
 			interrupts = <BCM6368_IRQ_EXT0>,
 				     <BCM6368_IRQ_EXT1>,
 				     <BCM6368_IRQ_EXT2>,
@@ -122,6 +123,7 @@
 			interrupt-controller;
 			#interrupt-cells = <2>;
 
+			interrupt-parent = <&periph_intc>;
 			interrupts = <BCM6368_IRQ_EXT4>,
 				     <BCM6368_IRQ_EXT5>;
 		};
@@ -149,6 +151,8 @@
 		};
 
 		gpio_cntl: syscon@10000080 {
+			#address-cells = <1>;
+			#size-cells = <1>;
 			compatible = "brcm,bcm6368-gpio-sysctl",
 				     "syscon", "simple-mfd";
 			reg = <0x10000080 0x80>;
-- 
2.30.2