From 873524c8517cf0986768685358d124aae7f7e495 Mon Sep 17 00:00:00 2001 From: H Hartley Sweeten Date: Tue, 13 Oct 2015 17:47:51 -0700 Subject: [PATCH] staging: comedi: cb_pcidas: tidy up cb_pcidas_trimpot_write() All the boards supported by this driver have an AD7376 or AD8402 trimpot. Replace the switch () with and if () and remove the unreachable dev_err() noise. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c b/drivers/staging/comedi/drivers/cb_pcidas.c index f22611b3edcd..2c6ef6eae095 100644 --- a/drivers/staging/comedi/drivers/cb_pcidas.c +++ b/drivers/staging/comedi/drivers/cb_pcidas.c @@ -634,18 +634,12 @@ static void cb_pcidas_trimpot_write(struct comedi_device *dev, { const struct cb_pcidas_board *board = dev->board_ptr; - switch (board->trimpot) { - case AD7376: + if (board->trimpot == AD7376) { /* write 7-bit value to trimpot */ cb_pcidas_calib_write(dev, val, 7, true); - break; - case AD8402: + } else { /* AD8402 */ /* write 10-bit channel/value to trimpot */ cb_pcidas_calib_write(dev, (chan << 8) | val, 10, true); - break; - default: - dev_err(dev->class_dev, "driver bug?\n"); - break; } } -- 2.30.2