From 85c41253d927ae6a31845d888780a4462efe61ef Mon Sep 17 00:00:00 2001 From: Jan Hoffmann Date: Thu, 30 Jan 2025 10:40:25 +0100 Subject: [PATCH] mediatek: fix TUF-AX4200 WAN LED With the current LED configuration using "mxl,led-config", the WAN LED stops working after the interface is brought down and up again. Since the driver also properly supports PHY LEDs now, switch to that instead. This makes the LED work properly, but requires configuration from userspace. Fixes: #17782 Signed-off-by: Jan Hoffmann Link: https://github.com/openwrt/openwrt/pull/17785 Signed-off-by: Robert Marko --- .../linux/mediatek/dts/mt7986a-asus-tuf-ax4200.dts | 12 ++++++++++-- .../mediatek/filogic/base-files/etc/board.d/01_leds | 3 +++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/target/linux/mediatek/dts/mt7986a-asus-tuf-ax4200.dts b/target/linux/mediatek/dts/mt7986a-asus-tuf-ax4200.dts index e40602fa215e..9f015cca9ba5 100644 --- a/target/linux/mediatek/dts/mt7986a-asus-tuf-ax4200.dts +++ b/target/linux/mediatek/dts/mt7986a-asus-tuf-ax4200.dts @@ -136,8 +136,16 @@ reset-assert-us = <10000>; reset-deassert-us = <10000>; - /* LED0: CONN (WAN white) */ - mxl,led-config = <0x03f0 0x0 0x0 0x0>; + leds { + #address-cells = <1>; + #size-cells = <0>; + + led@0 { + reg = <0>; + color = ; + function = LED_FUNCTION_WAN; + }; + }; }; switch: switch@1f { diff --git a/target/linux/mediatek/filogic/base-files/etc/board.d/01_leds b/target/linux/mediatek/filogic/base-files/etc/board.d/01_leds index fded01a73ea7..c1e4cec05443 100644 --- a/target/linux/mediatek/filogic/base-files/etc/board.d/01_leds +++ b/target/linux/mediatek/filogic/base-files/etc/board.d/01_leds @@ -11,6 +11,9 @@ abt,asr3000) ucidef_set_led_netdev "wlan2g" "WLAN2G" "green:wlan-2ghz" "phy0-ap0" ucidef_set_led_netdev "wlan5g" "WLAN5G" "green:wlan-5ghz" "phy1-ap0" ;; +asus,tuf-ax4200) + ucidef_set_led_netdev "wan" "WAN" "mdio-bus:06:white:wan" "eth1" "link tx rx" + ;; confiabits,mt7981) ucidef_set_led_netdev "lan1" "lan1" "blue:lan-1" "lan1" "link tx rx" ucidef_set_led_netdev "lan2" "lan2" "blue:lan-2" "lan2" "link tx rx" -- 2.30.2