From 81c246638182bad2f3c13dd9ab66b36e921e219b Mon Sep 17 00:00:00 2001 From: Hauke Mehrtens Date: Fri, 8 Aug 2014 22:52:28 +0000 Subject: [PATCH] brcm47xx: fix reboot problem on BCM4705/BCM4785 MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This adds some code based on code from the Broadcom GPL tar to fix the reboot problems on BCM4705/BCM4785. I tried rebooting my device for ~10 times and have never seen a problem. This reverts the changes in the previous commit and adds the real fix as suggested by Rafał. Setting bit 22 in Reg 22, sel 4 puts the BIU (Bus Interface Unit) into async mode. Signed-off-by: Hauke Mehrtens SVN-Revision: 42083 --- .../144-make-reboot-more-reliable.patch | 41 +++++++++++++++---- ...ect-more-then-128-MiB-of-RAM-HIGHMEM.patch | 2 +- .../patches-3.10/170-fix-74k-cpu.patch | 2 +- ...xed-PHY-device-if-we-do-not-find-any.patch | 4 +- .../830-huawei_e970_support.patch | 4 +- .../980-wnr834b_no_cardbus_invariant.patch | 2 +- 6 files changed, 39 insertions(+), 16 deletions(-) diff --git a/target/linux/brcm47xx/patches-3.10/144-make-reboot-more-reliable.patch b/target/linux/brcm47xx/patches-3.10/144-make-reboot-more-reliable.patch index 036de1da3c3c..f1a343a0cc9f 100644 --- a/target/linux/brcm47xx/patches-3.10/144-make-reboot-more-reliable.patch +++ b/target/linux/brcm47xx/patches-3.10/144-make-reboot-more-reliable.patch @@ -1,17 +1,40 @@ +From 26db431400c336c4cc658cb4888bab18d254c64a Mon Sep 17 00:00:00 2001 +From: Hauke Mehrtens +Date: Sat, 9 Aug 2014 00:00:09 +0200 +Subject: [PATCH] MIPS: BCM47XX: fix reboot problem on BCM4705/BCM4785 + +This adds some code based on code from the Broadcom GPL tar to fix the +reboot problems on BCM4705/BCM4785. I tried rebooting my device for ~10 +times and have never seen a problem. This reverts the changes in the +previous commit and adds the real fix as suggested by Rafał. + +Setting bit 22 in Reg 22, sel 4 puts the BIU (Bus Interface Unit) into +async mode. + +The previous try was this: +commit 316cad5c1d4daee998cd1f83ccdb437f6f20d45c +Author: Hauke Mehrtens +Date: Mon Jul 28 23:53:57 2014 +0200 + + MIPS: BCM47XX: make reboot more relaiable + +Signed-off-by: Hauke Mehrtens --- a/arch/mips/bcm47xx/setup.c +++ b/arch/mips/bcm47xx/setup.c -@@ -55,12 +55,12 @@ static void bcm47xx_machine_restart(char +@@ -55,7 +55,16 @@ static void bcm47xx_machine_restart(char switch (bcm47xx_bus_type) { #ifdef CONFIG_BCM47XX_SSB case BCM47XX_BUS_TYPE_SSB: -- ssb_watchdog_timer_set(&bcm47xx_bus.ssb, 1); -+ ssb_watchdog_timer_set(&bcm47xx_bus.ssb, 3); ++ if (bcm47xx_bus.bcma.bus.chipinfo.id == 0x4785) ++ write_c0_diag4(1 << 22); + ssb_watchdog_timer_set(&bcm47xx_bus.ssb, 1); ++ if (bcm47xx_bus.bcma.bus.chipinfo.id == 0x4785) { ++ __asm__ __volatile__( ++ ".set\tmips3\n\t" ++ "sync\n\t" ++ "wait\n\t" ++ ".set\tmips0"); ++ } break; #endif #ifdef CONFIG_BCM47XX_BCMA - case BCM47XX_BUS_TYPE_BCMA: -- bcma_chipco_watchdog_timer_set(&bcm47xx_bus.bcma.bus.drv_cc, 1); -+ bcma_chipco_watchdog_timer_set(&bcm47xx_bus.bcma.bus.drv_cc, 3); - break; - #endif - } diff --git a/target/linux/brcm47xx/patches-3.10/153-MIPS-BCM47XX-Detect-more-then-128-MiB-of-RAM-HIGHMEM.patch b/target/linux/brcm47xx/patches-3.10/153-MIPS-BCM47XX-Detect-more-then-128-MiB-of-RAM-HIGHMEM.patch index cd726b09e4b6..ed5695dca3d4 100644 --- a/target/linux/brcm47xx/patches-3.10/153-MIPS-BCM47XX-Detect-more-then-128-MiB-of-RAM-HIGHMEM.patch +++ b/target/linux/brcm47xx/patches-3.10/153-MIPS-BCM47XX-Detect-more-then-128-MiB-of-RAM-HIGHMEM.patch @@ -132,7 +132,7 @@ Signed-off-by: Ralf Baechle +#endif /* defined(CONFIG_BCM47XX_BCMA) && defined(CONFIG_HIGHMEM) */ --- a/arch/mips/bcm47xx/setup.c +++ b/arch/mips/bcm47xx/setup.c -@@ -214,6 +214,9 @@ void __init plat_mem_setup(void) +@@ -223,6 +223,9 @@ void __init plat_mem_setup(void) bcm47xx_bus_type = BCM47XX_BUS_TYPE_BCMA; bcm47xx_register_bcma(); bcm47xx_set_system_type(bcm47xx_bus.bcma.bus.chipinfo.id); diff --git a/target/linux/brcm47xx/patches-3.10/170-fix-74k-cpu.patch b/target/linux/brcm47xx/patches-3.10/170-fix-74k-cpu.patch index b5ff08467a03..2cdd887a182f 100644 --- a/target/linux/brcm47xx/patches-3.10/170-fix-74k-cpu.patch +++ b/target/linux/brcm47xx/patches-3.10/170-fix-74k-cpu.patch @@ -22,7 +22,7 @@ Acked-by: Rafa? Mi?ecki #include #include #include -@@ -234,6 +235,31 @@ void __init plat_mem_setup(void) +@@ -243,6 +244,31 @@ void __init plat_mem_setup(void) mips_set_machine_name(bcm47xx_board_get_name()); } diff --git a/target/linux/brcm47xx/patches-3.10/208-b44-use-fixed-PHY-device-if-we-do-not-find-any.patch b/target/linux/brcm47xx/patches-3.10/208-b44-use-fixed-PHY-device-if-we-do-not-find-any.patch index 7bf236c86f38..ae539a321521 100644 --- a/target/linux/brcm47xx/patches-3.10/208-b44-use-fixed-PHY-device-if-we-do-not-find-any.patch +++ b/target/linux/brcm47xx/patches-3.10/208-b44-use-fixed-PHY-device-if-we-do-not-find-any.patch @@ -30,7 +30,7 @@ Signed-off-by: David S. Miller #include #include #include -@@ -260,6 +263,12 @@ static int __init bcm47xx_cpu_fixes(void +@@ -269,6 +272,12 @@ static int __init bcm47xx_cpu_fixes(void } arch_initcall(bcm47xx_cpu_fixes); @@ -43,7 +43,7 @@ Signed-off-by: David S. Miller static int __init bcm47xx_register_bus_complete(void) { switch (bcm47xx_bus_type) { -@@ -278,6 +287,7 @@ static int __init bcm47xx_register_bus_c +@@ -287,6 +296,7 @@ static int __init bcm47xx_register_bus_c bcm47xx_buttons_register(); bcm47xx_leds_register(); bcm47xx_workarounds(); diff --git a/target/linux/brcm47xx/patches-3.10/830-huawei_e970_support.patch b/target/linux/brcm47xx/patches-3.10/830-huawei_e970_support.patch index ca5ae5a6746c..6aaac837ccc5 100644 --- a/target/linux/brcm47xx/patches-3.10/830-huawei_e970_support.patch +++ b/target/linux/brcm47xx/patches-3.10/830-huawei_e970_support.patch @@ -8,7 +8,7 @@ #include #include #include -@@ -269,6 +270,33 @@ static struct fixed_phy_status bcm47xx_f +@@ -278,6 +279,33 @@ static struct fixed_phy_status bcm47xx_f .duplex = DUPLEX_FULL, }; @@ -42,7 +42,7 @@ static int __init bcm47xx_register_bus_complete(void) { switch (bcm47xx_bus_type) { -@@ -288,6 +316,7 @@ static int __init bcm47xx_register_bus_c +@@ -297,6 +325,7 @@ static int __init bcm47xx_register_bus_c bcm47xx_leds_register(); bcm47xx_workarounds(); fixed_phy_add(PHY_POLL, 0, &bcm47xx_fixed_phy_status); diff --git a/target/linux/brcm47xx/patches-3.10/980-wnr834b_no_cardbus_invariant.patch b/target/linux/brcm47xx/patches-3.10/980-wnr834b_no_cardbus_invariant.patch index 650f02f2a13a..8bab5f09bfab 100644 --- a/target/linux/brcm47xx/patches-3.10/980-wnr834b_no_cardbus_invariant.patch +++ b/target/linux/brcm47xx/patches-3.10/980-wnr834b_no_cardbus_invariant.patch @@ -1,6 +1,6 @@ --- a/arch/mips/bcm47xx/setup.c +++ b/arch/mips/bcm47xx/setup.c -@@ -127,6 +127,10 @@ static int bcm47xx_get_invariants(struct +@@ -136,6 +136,10 @@ static int bcm47xx_get_invariants(struct if (bcm47xx_nvram_getenv("cardbus", buf, sizeof(buf)) >= 0) iv->has_cardbus_slot = !!simple_strtoul(buf, NULL, 10); -- 2.30.2