From 81980c16e27cc87c10265e7c62779ccabcaf456b Mon Sep 17 00:00:00 2001 From: Eduardo Barretto Date: Fri, 19 Dec 2014 23:34:33 -0200 Subject: [PATCH] Staging: wlan-ng: hfa384x_usb: fixed an 'else' statement coding style issue Removed useless 'else' statement that followed an 'if' statement that had a return 1 and moved all the content from the 'else' to outside of the switch case, this way if any case is sufficient it returns '1', otherwise it will return 0. Signed-off-by: Eduardo Barretto Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wlan-ng/hfa384x_usb.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 55d2f563e308..de33a07904f2 100644 --- a/drivers/staging/wlan-ng/hfa384x_usb.c +++ b/drivers/staging/wlan-ng/hfa384x_usb.c @@ -4123,12 +4123,11 @@ static int hfa384x_isgood_pdrcode(u16 pdrcode) pr_debug("Encountered unknown PDR#=0x%04x, assuming it's ok.\n", pdrcode); return 1; - } else { - /* bad code */ - pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n", - pdrcode); - return 0; } + break; } - return 0; /* avoid compiler warnings */ + /* bad code */ + pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n", + pdrcode); + return 0; } -- 2.30.2