From 79276eb2430d02c84a31fc5613e41aba05429184 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Sun, 16 Sep 2018 07:20:21 +0200 Subject: [PATCH] efi_loader: memory leak in efi_set_bootdev() efi_set_bootdev() may be called repeatedly. Free the memory allocated for device paths in previous calls. Signed-off-by: Heinrich Schuchardt Signed-off-by: Alexander Graf --- cmd/bootefi.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/cmd/bootefi.c b/cmd/bootefi.c index d6366c3e26..c8812b0f5e 100644 --- a/cmd/bootefi.c +++ b/cmd/bootefi.c @@ -603,6 +603,13 @@ void efi_set_bootdev(const char *dev, const char *devnr, const char *path) char filename[32] = { 0 }; /* dp->str is u16[32] long */ char *s; + /* efi_set_bootdev is typically called repeatedly, recover memory */ + efi_free_pool(bootefi_device_path); + efi_free_pool(bootefi_image_path); + /* If blk_get_device_part_str fails, avoid duplicate free. */ + bootefi_device_path = NULL; + bootefi_image_path = NULL; + if (strcmp(dev, "Net")) { struct blk_desc *desc; disk_partition_t fs_partition; -- 2.30.2