From 63d9bcb6825fac92fd7dfa4ba858c8d5aafa23e8 Mon Sep 17 00:00:00 2001 From: Jo-Philipp Wich Date: Thu, 23 Dec 2021 17:09:13 +0100 Subject: [PATCH] luci.js: remove unsafe fallback code from dom.parse() Do not fallback to .innerHTML if DOMParser() failed for whatever reason. Signed-off-by: Jo-Philipp Wich --- .../luci-base/htdocs/luci-static/resources/luci.js | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/modules/luci-base/htdocs/luci-static/resources/luci.js b/modules/luci-base/htdocs/luci-static/resources/luci.js index fcab3a4018..78e8b8b30b 100644 --- a/modules/luci-base/htdocs/luci-static/resources/luci.js +++ b/modules/luci-base/htdocs/luci-static/resources/luci.js @@ -1248,7 +1248,7 @@ * `null` on parsing failures or if no element could be found. */ parse: function(s) { - var elem; + var elem = null; try { domParser = domParser || new DOMParser(); @@ -1256,16 +1256,7 @@ } catch(e) {} - if (!elem) { - try { - dummyElem = dummyElem || document.createElement('div'); - dummyElem.innerHTML = s; - elem = dummyElem.firstChild; - } - catch (e) {} - } - - return elem || null; + return elem; }, /** -- 2.30.2