From 5a59e2c059866bb8ca5b41cce34d49b2ddbd3a4e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Rafa=C5=82=20Mi=C5=82ecki?= Date: Tue, 25 Dec 2018 20:30:12 +0100 Subject: [PATCH] samba36: append config from /var/run/config/ for runtime shares MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This will allow automation/hotplug.d scripts to store runtime shares in the /var/run/config/samba. It's useful e.g. for USB drives that user wants to be automatically shared. Using /var/run/config/ provides: 1) Automated cleaning on reboots It's important for consistency (to avoid sharing non-existing drives) 2) Safety for user non-commited changes Automated scripts should never call "uci [foo] commit" as that could flush incomplete config. Another minor gain is avoiding flash wearing for runtime setup. Cc: Rosy Song Cc: Jo-Philipp Wich Signed-off-by: Rafał Miłecki --- package/network/services/samba36/files/samba.init | 2 ++ 1 file changed, 2 insertions(+) diff --git a/package/network/services/samba36/files/samba.init b/package/network/services/samba36/files/samba.init index 1c5bb3b3c43..abe8e8f5c71 100755 --- a/package/network/services/samba36/files/samba.init +++ b/package/network/services/samba36/files/samba.init @@ -84,6 +84,8 @@ smb_add_share() { init_config() { config_load samba + CONFIG_APPEND=1 UCI_CONFIG_DIR=/var/run/config config_load samba + config_foreach smb_header samba config_foreach smb_add_share sambashare } -- 2.30.2