From 59d07ee08e858bf2c121d0cdc6c8ddd3b26ee5b1 Mon Sep 17 00:00:00 2001 From: Andre Przywara Date: Fri, 8 Jul 2016 15:18:35 +0100 Subject: [PATCH] SPL: tiny-printf: avoid any BSS usage As printf calls may be executed quite early, we should avoid using any BSS stored variables, since some boards put BSS in DRAM, which may not have been initialised yet. Explicitly mark those "static global" variables as belonging to the .data section, to keep tiny-printf clear of any BSS usage. Signed-off-by: Andre Przywara --- lib/tiny-printf.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/tiny-printf.c b/lib/tiny-printf.c index 451f4f7a67..b334f053cc 100644 --- a/lib/tiny-printf.c +++ b/lib/tiny-printf.c @@ -13,11 +13,16 @@ #include #include -static char *bf; -static char zs; +/* + * This code in here may execute before the DRAM is initialised, so + * we should make sure that it doesn't touch BSS, which some boards + * put in DRAM. + */ +static char *bf __attribute__ ((section(".data"))); +static char zs __attribute__ ((section(".data"))); /* Current position in sprintf() output string */ -static char *outstr; +static char *outstr __attribute__ ((section(".data"))); static void out(char c) { -- 2.30.2