From 58af272b333eeba428ca53b5b80dbbcf120fe57a Mon Sep 17 00:00:00 2001 From: "Tobin C. Harding" Date: Wed, 22 Mar 2017 11:59:52 +1100 Subject: [PATCH] staging: ks7010: fix memcmp() bug Call site to memcmp() treats return value as if it were an error code, it is not. If memcmp() finds inputs to be not the same, an error return code should be set explicitly. Correctly handle return value from call to memcmp(), set error code explicitly. Reported-by: Dan Carpenter Signed-off-by: Tobin C. Harding Signed-off-by: Greg Kroah-Hartman --- drivers/staging/ks7010/ks7010_sdio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index 28b91be8415c..dbb1f0538b48 100644 --- a/drivers/staging/ks7010/ks7010_sdio.c +++ b/drivers/staging/ks7010/ks7010_sdio.c @@ -695,8 +695,8 @@ static int ks7010_sdio_data_compare(struct ks_wlan_private *priv, u32 address, if (ret) goto err_free_read_buf; - ret = memcmp(data, read_buf, size); - if (ret) { + if (memcmp(data, read_buf, size) != 0) { + ret = -EIO; DPRINTK(0, "data compare error (%d)\n", ret); goto err_free_read_buf; } -- 2.30.2