From 543a2a970c062c30ac33f49f67ea952eb0adbed3 Mon Sep 17 00:00:00 2001 From: Florian Eckert Date: Mon, 8 Mar 2021 16:30:53 +0100 Subject: [PATCH] collectd: fix smart disk detection On my system the attribute DEVTYPE was not set. The plugin could not read any data and the function call blocked forever on this function and did not returned. By removing it, all block devices under `/sys/class/block` were checked. Block devices that do not support SMART were not evaluated. The collected displays the following message. smart plugin: checking SMART status of /dev/loop4. smart plugin: unable to open /dev/loop4. If you do not like this message, you could only enable device in the uci that does support SMART. Signed-off-by: Florian Eckert --- utils/collectd/patches/933-fix-smart-detection.patch | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 utils/collectd/patches/933-fix-smart-detection.patch diff --git a/utils/collectd/patches/933-fix-smart-detection.patch b/utils/collectd/patches/933-fix-smart-detection.patch new file mode 100644 index 0000000000..70250d61b5 --- /dev/null +++ b/utils/collectd/patches/933-fix-smart-detection.patch @@ -0,0 +1,10 @@ +--- a/src/smart.c ++++ b/src/smart.c +@@ -610,7 +610,6 @@ static int smart_read(void) { + return -1; + } + udev_enumerate_add_match_subsystem(enumerate, "block"); +- udev_enumerate_add_match_property(enumerate, "DEVTYPE", "disk"); + udev_enumerate_scan_devices(enumerate); + devices = udev_enumerate_get_list_entry(enumerate); + if (devices == NULL) { -- 2.30.2