From 5140a8ceaa369d362d0ab7a438a5d99c75ee098d Mon Sep 17 00:00:00 2001 From: Tim Gardner Date: Fri, 1 Mar 2013 19:46:48 +0800 Subject: [PATCH] autofs4 - autofs4_catatonic_mode(): remove redundant null check on kfree() smatch analysis: fs/autofs4/waitq.c:46 autofs4_catatonic_mode() info: redundant null check on wq->name.name calling kfree() Signed-off-by: Tim Gardner Signed-off-by: Ian Kent Cc: autofs@vger.kernel.org Signed-off-by: Linus Torvalds --- fs/autofs4/waitq.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c index 03bc1d347d8e..3db70dae40d3 100644 --- a/fs/autofs4/waitq.c +++ b/fs/autofs4/waitq.c @@ -42,10 +42,8 @@ void autofs4_catatonic_mode(struct autofs_sb_info *sbi) while (wq) { nwq = wq->next; wq->status = -ENOENT; /* Magic is gone - report failure */ - if (wq->name.name) { - kfree(wq->name.name); - wq->name.name = NULL; - } + kfree(wq->name.name); + wq->name.name = NULL; wq->wait_ctr--; wake_up_interruptible(&wq->queue); wq = nwq; -- 2.30.2