From 4c746fc56c3e849a297d42cbc00115bd590b1216 Mon Sep 17 00:00:00 2001 From: Michalis Pappas Date: Sat, 24 Mar 2018 12:38:31 +0800 Subject: [PATCH] qemu: MULTI_CONSOLE_API=0 causes build error Add crash_console_init declaration to console.h Only enable MULTI_CONSOLE_API for AArch64 Fixes ARM-software/tf-issues#571 Signed-off-by: Michalis Pappas --- include/drivers/console.h | 2 ++ plat/qemu/platform.mk | 7 ++++++- plat/qemu/qemu_console.c | 2 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/include/drivers/console.h b/include/drivers/console.h index f8ec83d2..c8a43a28 100644 --- a/include/drivers/console.h +++ b/include/drivers/console.h @@ -66,6 +66,8 @@ int console_flush(void); /* REMOVED on AArch64 -- use console__register() instead! */ int console_init(uintptr_t base_addr, unsigned int uart_clk, unsigned int baud_rate); +int console_core_init(uintptr_t base_addr, + unsigned int uart_clk, unsigned int baud_rate); void console_uninit(void); #endif diff --git a/plat/qemu/platform.mk b/plat/qemu/platform.mk index a9fbcd73..017807b0 100644 --- a/plat/qemu/platform.mk +++ b/plat/qemu/platform.mk @@ -169,7 +169,12 @@ $(eval $(call TOOL_ADD_IMG,bl32_extra2,--tos-fw-extra2)) endif SEPARATE_CODE_AND_RODATA := 1 -MULTI_CONSOLE_API := 1 + +# Use MULTI_CONSOLE_API by default only on AArch64 +# as it is not yet supported on AArch32 +ifeq ($(ARCH),aarch64) +MULTI_CONSOLE_API := 1 +endif # Disable the PSCI platform compatibility layer ENABLE_PLAT_COMPAT := 0 diff --git a/plat/qemu/qemu_console.c b/plat/qemu/qemu_console.c index 9c02957e..1cf84aa7 100644 --- a/plat/qemu/qemu_console.c +++ b/plat/qemu/qemu_console.c @@ -7,8 +7,10 @@ #include #include +#if MULTI_CONSOLE_API static console_pl011_t console; static console_pl011_t crash_console; +#endif /* MULTI_CONSOLE_API */ void qemu_console_init(void) { -- 2.30.2