From 496baea013b6c9ef7eaf80facc50b4317e5cd39c Mon Sep 17 00:00:00 2001 From: Bhumika Goyal Date: Wed, 17 Feb 2016 01:01:58 +0530 Subject: [PATCH] Staging: lustre: lov: Pull assignments out of function call Assignments in function call arguments are undesirable. So pull such assignments out before function call. Made a coccinelle script to detect such cases: @@ expression fn,b,d; @@ * fn(...,d=b,...); Signed-off-by: Bhumika Goyal Signed-off-by: Greg Kroah-Hartman --- drivers/staging/lustre/lustre/lov/lov_merge.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/lov/lov_merge.c b/drivers/staging/lustre/lustre/lov/lov_merge.c index 97115bec7cca..029cd4d62796 100644 --- a/drivers/staging/lustre/lustre/lov/lov_merge.c +++ b/drivers/staging/lustre/lustre/lov/lov_merge.c @@ -129,7 +129,8 @@ int lov_adjust_kms(struct obd_export *exp, struct lov_stripe_md *lsm, "stripe %d KMS %sing %llu->%llu\n", stripe, kms > loi->loi_kms ? "increase":"shrink", loi->loi_kms, kms); - loi_kms_set(loi, loi->loi_lvb.lvb_size = kms); + loi->loi_lvb.lvb_size = kms; + loi_kms_set(loi, loi->loi_lvb.lvb_size); } return 0; } -- 2.30.2