From 425101e115946f29287c51b2ea2c3527978645aa Mon Sep 17 00:00:00 2001 From: Marek Vasut Date: Wed, 12 Sep 2012 20:15:06 +0200 Subject: [PATCH] serial: zoom2: Remove zoom2 serial prototypes from serial.h Remove the prototypes for zoom2_serial_deviceN from serial.h . This can't be done right away, as they are referenced from the zoom2 config file. Therefore, adjust the code so the config file only specifies number of the port. Then, replace the simple return in default_serial_console() with a switch across possible values, which returns the zoom2_serial_deviceN . With such adjustment in place, the exported prototypes in serial.h can be safely removed. Signed-off-by: Marek Vasut Cc: Marek Vasut Cc: Tom Rini --- board/logicpd/zoom2/zoom2_serial.c | 7 ++++++- include/configs/omap3_zoom2.h | 2 +- include/serial.h | 7 ------- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/board/logicpd/zoom2/zoom2_serial.c b/board/logicpd/zoom2/zoom2_serial.c index 74f165fa25..9b7aea8590 100644 --- a/board/logicpd/zoom2/zoom2_serial.c +++ b/board/logicpd/zoom2/zoom2_serial.c @@ -135,5 +135,10 @@ QUAD_INIT (3) struct serial_device *default_serial_console(void) { - return ZOOM2_DEFAULT_SERIAL_DEVICE; + switch (ZOOM2_DEFAULT_SERIAL_DEVICE) { + case 0: return &zoom2_serial_device0; + case 1: return &zoom2_serial_device1; + case 2: return &zoom2_serial_device2; + case 3: return &zoom2_serial_device3; + } } diff --git a/include/configs/omap3_zoom2.h b/include/configs/omap3_zoom2.h index 4447dff00d..a7cc5fc4f6 100644 --- a/include/configs/omap3_zoom2.h +++ b/include/configs/omap3_zoom2.h @@ -81,7 +81,7 @@ * 0 - 1 : first USB with respect to the left edge of the debug board * 2 - 3 : second USB with respect to the left edge of the debug board */ -#define ZOOM2_DEFAULT_SERIAL_DEVICE (&zoom2_serial_device0) +#define ZOOM2_DEFAULT_SERIAL_DEVICE 0 #define V_NS16550_CLK (1843200) /* 1.8432 Mhz */ diff --git a/include/serial.h b/include/serial.h index 5f9899ed21..01a86b44dd 100644 --- a/include/serial.h +++ b/include/serial.h @@ -39,13 +39,6 @@ extern struct serial_device serial1_device; extern struct serial_device eserial1_device; extern struct serial_device eserial2_device; -#if defined(CONFIG_OMAP3_ZOOM2) -extern struct serial_device zoom2_serial_device0; -extern struct serial_device zoom2_serial_device1; -extern struct serial_device zoom2_serial_device2; -extern struct serial_device zoom2_serial_device3; -#endif - extern void serial_register(struct serial_device *); extern void serial_initialize(void); extern void serial_stdio_init(void); -- 2.30.2