From 413db8c1c75a276c046ea476fee9364ca8df4d12 Mon Sep 17 00:00:00 2001 From: Jorgyano Vieira Date: Wed, 15 Feb 2012 00:20:06 -0200 Subject: [PATCH] Staging: crystalhd: crystalhd_misc: improved debug macros Improvement of debug macros to ensure safe use on if/else statements. Signed-off-by: Jorgyano Vieira Acked-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman --- drivers/staging/crystalhd/crystalhd_misc.h | 46 ++++++++++++---------- 1 file changed, 25 insertions(+), 21 deletions(-) diff --git a/drivers/staging/crystalhd/crystalhd_misc.h b/drivers/staging/crystalhd/crystalhd_misc.h index 4d6172357428..e0aa361c3934 100644 --- a/drivers/staging/crystalhd/crystalhd_misc.h +++ b/drivers/staging/crystalhd/crystalhd_misc.h @@ -203,26 +203,30 @@ enum _chd_log_levels { BCMLOG_ENTER_LEAVE = 0x00000008, /* stack tracking */ }; -#define BCMLOG_ENTER \ -if (g_linklog_level & BCMLOG_ENTER_LEAVE) { \ - printk(KERN_DEBUG "Entered %s\n", __func__); \ -} - -#define BCMLOG_LEAVE \ -if (g_linklog_level & BCMLOG_ENTER_LEAVE) { \ - printk(KERN_DEBUG "Leaving %s\n", __func__); \ -} - -#define BCMLOG(trace, fmt, args...) \ -if (g_linklog_level & trace) { \ - printk(fmt, ##args); \ -} - -#define BCMLOG_ERR(fmt, args...) \ -do { \ - if (g_linklog_level & BCMLOG_ERROR) { \ - printk(KERN_ERR "*ERR*:%s:%d: "fmt, __FILE__, __LINE__, ##args); \ - } \ -} while (0); +#define BCMLOG_ENTER \ +do { \ + if (g_linklog_level & BCMLOG_ENTER_LEAVE) \ + printk(KERN_DEBUG "Entered %s\n", __func__); \ +} while (0) + +#define BCMLOG_LEAVE \ +do { \ + if (g_linklog_level & BCMLOG_ENTER_LEAVE) \ + printk(KERN_DEBUG "Leaving %s\n", __func__); \ +} while (0) \ + +#define BCMLOG(trace, fmt, args...) \ +do { \ + if (g_linklog_level & trace) \ + printk(fmt, ##args); \ +} while (0) + + +#define BCMLOG_ERR(fmt, args...) \ +do { \ + if (g_linklog_level & BCMLOG_ERROR) \ + printk(KERN_ERR "*ERR*:%s:%d: "fmt, \ + __FILE__, __LINE__, ##args); \ +} while (0) #endif -- 2.30.2