From 38a2f12ec5abafda9b385b6ce9f68714349df264 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Petr=20=C5=A0tetiar?= Date: Fri, 1 Nov 2019 10:26:38 +0100 Subject: [PATCH] tests: shunit2: fix issues reported by shellcheck MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit In tests.sh line 10: [ -x $UCI_BIN ] || { ^------^ SC2086: Double quote to prevent globbing and word splitting. In tests.sh line 63: for suite in $(ls ${SCRIPTS_DIR}/*) ^--------------------^ SC2045: Iterating over ls output is fragile. Use globs. In tests.sh line 65: cat ${suite} >> ${FULL_SUITE} ^------^ SC2086: Double quote to prevent globbing and word splitting. Signed-off-by: Petr Å tetiar --- tests/shunit2/tests.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/shunit2/tests.sh b/tests/shunit2/tests.sh index a7c6d90..72c4874 100755 --- a/tests/shunit2/tests.sh +++ b/tests/shunit2/tests.sh @@ -7,7 +7,7 @@ TMP_DIR=${TESTS_DIR}"/tmp" FULL_SUITE=${TESTS_DIR}"/full_suite.sh" UCI_BIN=${UCI_BIN:-"../uci"} -[ -x $UCI_BIN ] || { +[ -x "$UCI_BIN" ] || { echo "uci is not present." >&2 return 1 } @@ -60,9 +60,9 @@ assertFailWithNoReturn() { } EOF -for suite in $(ls ${SCRIPTS_DIR}/*) +for suite in "${SCRIPTS_DIR}"/* do - cat ${suite} >> ${FULL_SUITE} + cat "${suite}" >> ${FULL_SUITE} done echo ". ${DO_TEST}" >> ${FULL_SUITE} -- 2.30.2