From 32afa6a2f5580eb2ea685ef21ee8774c347cd2ee Mon Sep 17 00:00:00 2001 From: Paul Donald Date: Thu, 25 Jan 2024 03:18:12 +0100 Subject: [PATCH] luci-base: fix docs for TableSection There are repeated values (TableSection inherits identically named values from TypedSection which do not make sense to recreate). There seemed to be other errors. E.g. TypedSection for FlagValue properties, which mean that TypedSection got tooltip + tooltipicon, and by virtue of the above error, GridSection inherited this too. Signed-off-by: Paul Donald (cherry picked from commit 0617d301d9e9bb876621e61600673daef200b182) --- .../htdocs/luci-static/resources/form.js | 50 ++----------------- 1 file changed, 3 insertions(+), 47 deletions(-) diff --git a/modules/luci-base/htdocs/luci-static/resources/form.js b/modules/luci-base/htdocs/luci-static/resources/form.js index 317b49fdfe..e62b4b92d3 100644 --- a/modules/luci-base/htdocs/luci-static/resources/form.js +++ b/modules/luci-base/htdocs/luci-static/resources/form.js @@ -2375,39 +2375,6 @@ var CBITypedSection = CBIAbstractSection.extend(/** @lends LuCI.form.TypedSectio var CBITableSection = CBITypedSection.extend(/** @lends LuCI.form.TableSection.prototype */ { __name__: 'CBI.TableSection', - /** - * If set to `true`, the user may add or remove instances from the form - * section widget, otherwise only preexisting sections may be edited. - * The default is `false`. - * - * @name LuCI.form.TableSection.prototype#addremove - * @type boolean - * @default false - */ - - /** - * If set to `true`, mapped section instances are treated as anonymous - * UCI sections, which means that section instance elements will be - * rendered without title element and that no name is required when adding - * new sections. The default is `false`. - * - * @name LuCI.form.TableSection.prototype#anonymous - * @type boolean - * @default false - */ - - /** - * Override the caption used for the section add button at the bottom of - * the section form element. If set to a string, it will be used as-is, - * if set to a function, the function will be invoked and its return value - * is used as caption, after converting it to a string. If this property - * is not set, the default is `Add`. - * - * @name LuCI.form.TableSection.prototype#addbtntitle - * @type string|function - * @default null - */ - /** * Override the per-section instance title caption shown in the first * column of the table unless `anonymous` is set to true. If set to a @@ -2438,17 +2405,6 @@ var CBITableSection = CBITypedSection.extend(/** @lends LuCI.form.TableSection.p * @default null */ - /** - * Override the UCI configuration name to read the section IDs from. By - * default, the configuration name is inherited from the parent `Map`. - * By setting this property, a deviating configuration may be specified. - * The default is `null`, means inheriting from the parent form. - * - * @name LuCI.form.TableSection.prototype#uciconfig - * @type string - * @default null - */ - /** * Specify a maximum amount of columns to display. By default, one table * column is rendered for each child option of the form section element. @@ -4028,18 +3984,18 @@ var CBIFlagValue = CBIValue.extend(/** @lends LuCI.form.FlagValue.prototype */ { * value will be shown as a tooltip. If the return value of the function * is `null` no tooltip will be set. * - * @name LuCI.form.TypedSection.prototype#tooltip + * @name LuCI.form.FlagValue.prototype#tooltip * @type string|function * @default null */ /** - * Set a tooltip icon. + * Set a tooltip icon for the flag option. * * If set, this icon will be shown for the default one. * This could also be a png icon from the resources directory. * - * @name LuCI.form.TypedSection.prototype#tooltipicon + * @name LuCI.form.FlagValue.prototype#tooltipicon * @type string * @default 'ℹ️'; */ -- 2.30.2