From 2da2317feda8c509299b6a890cdfbdf243c00436 Mon Sep 17 00:00:00 2001 From: Felix Fietkau Date: Sat, 6 Sep 2014 17:51:44 +0000 Subject: [PATCH] ar71xx: fix off-by-one error in packet descriptor splitting (patch from #13072) Signed-off-by: Felix Fietkau SVN-Revision: 42428 --- .../drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c index ed040333413..c04fb94b94e 100644 --- a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c +++ b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c @@ -704,7 +704,12 @@ static int ag71xx_fill_dma_desc(struct ag71xx_ring *ring, u32 addr, int len) if (cur_len > split) { cur_len = split; - if (len < split + 4) + + /* + * TX will hang if DMA transfers <= 4 bytes, + * make sure next segment is more than 4 bytes long. + */ + if (len <= split + 4) cur_len -= 4; } -- 2.30.2