From 1ee5e7dd5eced2ec13d3810c55b4ecd73cb5c92f Mon Sep 17 00:00:00 2001 From: Antti Palosaari Date: Fri, 5 Dec 2014 16:02:42 -0300 Subject: [PATCH] [media] si2168: add own goto label for kzalloc failure Use own label for kzalloc failure in which does not call kfree(). kfree() could be called with NULL, but it is still better to have own label which skips unnecessary kfree(). Signed-off-by: Antti Palosaari Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/si2168.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index f3fabd5fe455..06e54d10cc4f 100644 --- a/drivers/media/dvb-frontends/si2168.c +++ b/drivers/media/dvb-frontends/si2168.c @@ -672,7 +672,7 @@ static int si2168_probe(struct i2c_client *client, if (!dev) { ret = -ENOMEM; dev_err(&client->dev, "kzalloc() failed\n"); - goto err_kfree; + goto err; } mutex_init(&dev->i2c_mutex); @@ -700,6 +700,7 @@ static int si2168_probe(struct i2c_client *client, return 0; err_kfree: kfree(dev); +err: dev_dbg(&client->dev, "failed=%d\n", ret); return ret; } -- 2.30.2