From 1d40c8a9f28d43f0b5cbfaea907b3283165b0490 Mon Sep 17 00:00:00 2001 From: =?utf8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Date: Mon, 18 May 2020 09:19:06 +0200 Subject: [PATCH] bcm63xx: ext_intc: fix warning MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit In file included from ./arch/mips/include/asm/io.h:34, from ./arch/mips/include/asm/mmiowb.h:5, from ./include/linux/spinlock.h:60, from ./include/linux/irq.h:14, from drivers/irqchip/irq-bcm6345-ext.c:10: drivers/irqchip/irq-bcm6345-ext.c: In function 'bcm6345_ext_intc_of_init': ./arch/mips/include/asm/mach-bcm63xx/ioremap.h:48:9: warning: 'base' may be used uninitialized in this function [-Wmaybe-uninitialized] return is_bcm63xx_internal_registers((unsigned long)addr); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/irqchip/irq-bcm6345-ext.c:255:16: note: 'base' was declared here void __iomem *base; ^~~~ Signed-off-by: Álvaro Fernández Rojas (cherry picked from commit 29c3bb5f413f0962971c66e6516b8409a78e0135) --- ...6345-external-fix-base-uninitialized.patch | 28 +++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 target/linux/brcm63xx/patches-4.14/325-irqchip-bcm6345-external-fix-base-uninitialized.patch diff --git a/target/linux/brcm63xx/patches-4.14/325-irqchip-bcm6345-external-fix-base-uninitialized.patch b/target/linux/brcm63xx/patches-4.14/325-irqchip-bcm6345-external-fix-base-uninitialized.patch new file mode 100644 index 0000000000..45b5118a4a --- /dev/null +++ b/target/linux/brcm63xx/patches-4.14/325-irqchip-bcm6345-external-fix-base-uninitialized.patch @@ -0,0 +1,28 @@ +--- a/drivers/irqchip/irq-bcm6345-ext.c ++++ b/drivers/irqchip/irq-bcm6345-ext.c +@@ -271,21 +271,19 @@ static int __init bcm6345_ext_intc_of_in + + for (i = 0; i < num_irqs; i++) { + irqs[i] = irq_of_parse_and_map(node, i); +- if (!irqs[i]) { +- ret = -ENOMEM; +- goto out_unmap; +- } ++ if (!irqs[i]) ++ return -ENOMEM; + } + + base = of_iomap(node, 0); + if (!base) +- goto out_unmap; ++ return -ENXIO; + + ret = __bcm6345_ext_intc_init(node, num_irqs, irqs, base, shift, + toggle_clear_on_ack); + if (!ret) + return 0; +-out_unmap: ++ + iounmap(base); + + for (i = 0; i < num_irqs; i++) -- 2.30.2