From 1b438b454085238b44875ac6cd508fc1106f07d1 Mon Sep 17 00:00:00 2001 From: Philipp Zabel Date: Tue, 18 Jun 2019 12:45:24 -0400 Subject: [PATCH] media: coda: mark the last output buffer on decoder stop command Mark the last output buffer to be decoded and only copy pending queued output buffers into the bitstream ring buffer in the BIT processor decoder case. Signed-off-by: Philipp Zabel Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/coda/coda-bit.c | 3 +++ drivers/media/platform/coda/coda-common.c | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/drivers/media/platform/coda/coda-bit.c b/drivers/media/platform/coda/coda-bit.c index bfe6019e68a8..cbcec571a014 100644 --- a/drivers/media/platform/coda/coda-bit.c +++ b/drivers/media/platform/coda/coda-bit.c @@ -312,6 +312,9 @@ static bool coda_bitstream_try_queue(struct coda_ctx *ctx, if (ctx == v4l2_m2m_get_curr_priv(ctx->dev->m2m_dev)) coda_kfifo_sync_to_device_write(ctx); + /* Set the stream-end flag after the last buffer is queued */ + if (src_buf->flags & V4L2_BUF_FLAG_LAST) + coda_bit_stream_end_flag(ctx); ctx->hold = false; return true; diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c index 935e8c408feb..b35e6ea70424 100644 --- a/drivers/media/platform/coda/coda-common.c +++ b/drivers/media/platform/coda/coda-common.c @@ -1071,6 +1071,7 @@ static int coda_decoder_cmd(struct file *file, void *fh, { struct coda_ctx *ctx = fh_to_ctx(fh); struct coda_dev *dev = ctx->dev; + struct vb2_v4l2_buffer *buf; struct vb2_queue *dst_vq; int ret; @@ -1092,6 +1093,11 @@ static int coda_decoder_cmd(struct file *file, void *fh, mutex_unlock(&ctx->bitstream_mutex); break; case V4L2_DEC_CMD_STOP: + buf = v4l2_m2m_last_src_buf(ctx->fh.m2m_ctx); + if (buf) + /* Mark last buffer */ + buf->flags |= V4L2_BUF_FLAG_LAST; + /* Set the stream-end flag on this context */ coda_bit_stream_end_flag(ctx); ctx->hold = false; -- 2.30.2