From 18aa062d491988d6fa15092b7ed92cc6f9e44b6d Mon Sep 17 00:00:00 2001 From: Hans Dedecker Date: Mon, 1 Feb 2016 10:56:18 +0100 Subject: [PATCH] tunnel: Fix uninitialized access Fix tb_dev uninitialized access by device_init_settings Signed-off-by: Hans Dedecker --- tunnel.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tunnel.c b/tunnel.c index aa670a3..524fd43 100644 --- a/tunnel.c +++ b/tunnel.c @@ -49,12 +49,11 @@ tunnel_reload(struct device *dev, struct blob_attr *attr) if (uci_blob_check_equal(dev->config, attr, cfg)) return DEV_CONFIG_NO_CHANGE; - if (attr) { - memset(tb_dev, 0, sizeof(tb_dev)); + memset(tb_dev, 0, sizeof(tb_dev)); + if (attr) blobmsg_parse(device_attr_list.params, __DEV_ATTR_MAX, tb_dev, blob_data(attr), blob_len(attr)); - } device_init_settings(dev, tb_dev); -- 2.30.2