From 00a326a7360e5e172962e65392e85308e847997e Mon Sep 17 00:00:00 2001 From: Daniel Golle Date: Sun, 14 Mar 2021 19:04:20 +0000 Subject: [PATCH] firmware-utils/ptgen: remove unused variable assignment Discovered by coverty: CID 1473630: Code maintainability issues (UNUSED_VALUE) Assigning value from "type_to_guid_and_name(type, &name)" to "part_guid" here, but that stored value is overwritten before it can be used. Remove the now redundant assignment of part_guid which is also set conditionally later on. Fixes: 4a078bd135 ("firmware-utils/ptgen: fix partition guid and name") Signed-off-by: Daniel Golle --- tools/firmware-utils/src/ptgen.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/firmware-utils/src/ptgen.c b/tools/firmware-utils/src/ptgen.c index 1eed21393d8..d911b9d1f01 100644 --- a/tools/firmware-utils/src/ptgen.c +++ b/tools/firmware-utils/src/ptgen.c @@ -630,7 +630,6 @@ int main (int argc, char **argv) break; case 't': type = (char)strtoul(optarg, NULL, 16); - part_guid = type_to_guid_and_name(type, &name); break; case 'a': active = (int)strtoul(optarg, NULL, 0); -- 2.30.2