drm/i915/breadcrumbs: Ignore unsubmitted signalers
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 6 Feb 2018 09:46:33 +0000 (09:46 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 7 Feb 2018 11:05:21 +0000 (11:05 +0000)
commitfd10e2ce9905030d922e179a8047a4d50daffd8e
tree2a8a376b27fb42a8b1748181a0540846767c6e7d
parent2f2f2db86d63605b1f57780ead21d4968e9d0bf3
drm/i915/breadcrumbs: Ignore unsubmitted signalers

When a request is preempted, it is unsubmitted from the HW queue and
removed from the active list of breadcrumbs. In the process, this
however triggers the signaler and it may see the clear rbtree with the
old, and still valid, seqno, or it may match the cleared seqno with the
now zero rq->global_seqno. This confuses the signaler into action and
signaling the fence.

Fixes: d6a2289d9d6b ("drm/i915: Remove the preempted request from the execution queue")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: <stable@vger.kernel.org> # v4.12+
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180206094633.30181-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/intel_breadcrumbs.c