sr: pass down correctly sized SCSI sense buffer
authorJens Axboe <axboe@kernel.dk>
Mon, 21 May 2018 18:21:14 +0000 (12:21 -0600)
committerJens Axboe <axboe@kernel.dk>
Mon, 21 May 2018 18:21:14 +0000 (12:21 -0600)
commitf7068114d45ec55996b9040e98111afa56e010fe
tree32c53bcae79c32537ffe622d7654d69f60ebd6f7
parent1c1a2ee1b53b006754073eefc65d2b2cedb5264b
sr: pass down correctly sized SCSI sense buffer

We're casting the CDROM layer request_sense to the SCSI sense
buffer, but the former is 64 bytes and the latter is 96 bytes.
As we generally allocate these on the stack, we end up blowing
up the stack.

Fix this by wrapping the scsi_execute() call with a properly
sized sense buffer, and copying back the bits for the CDROM
layer.

Cc: stable@vger.kernel.org
Reported-by: Piotr Gabriel Kosinski <pg.kosinski@gmail.com>
Reported-by: Daniel Shapira <daniel@twistlock.com>
Tested-by: Kees Cook <keescook@chromium.org>
Fixes: 82ed4db499b8 ("block: split scsi_request out of struct request")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/scsi/sr_ioctl.c