gfs2: Don't demote a glock until its revokes are written
authorBob Peterson <rpeterso@redhat.com>
Wed, 13 Nov 2019 20:08:45 +0000 (14:08 -0600)
committerBob Peterson <rpeterso@redhat.com>
Thu, 27 Feb 2020 13:53:18 +0000 (07:53 -0600)
commitdf5db5f9ee112e76b5202fbc331f990a0fc316d6
tree1af50ad1f05b65890ba8265c05b50bacdfe1020e
parent2ca0c2fbf3ed7f9609333a996149d02f70e8a6f3
gfs2: Don't demote a glock until its revokes are written

Before this patch, run_queue would demote glocks based on whether
there are any more holders. But if the glock has pending revokes that
haven't been written to the media, giving up the glock might end in
file system corruption if the revokes never get written due to
io errors, node crashes and fences, etc. In that case, another node
will replay the metadata blocks associated with the glock, but
because the revoke was never written, it could replay that block
even though the glock had since been granted to another node who
might have made changes.

This patch changes the logic in run_queue so that it never demotes
a glock until its count of pending revokes reaches zero.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/glock.c