pid: Fix error return value in some cases
authorCorey Minyard <cminyard@mvista.com>
Fri, 6 Mar 2020 17:23:14 +0000 (11:23 -0600)
committerChristian Brauner <christian.brauner@ubuntu.com>
Sun, 8 Mar 2020 13:22:58 +0000 (14:22 +0100)
commitb26ebfe12f34f372cf041c6f801fa49c3fb382c5
tree9a5d22df7e6984674e9c6ae186536dd80022ba15
parent98d54f81e36ba3bf92172791eba5ca5bd813989b
pid: Fix error return value in some cases

Recent changes to alloc_pid() allow the pid number to be specified on
the command line.  If set_tid_size is set, then the code scanning the
levels will hard-set retval to -EPERM, overriding it's previous -ENOMEM
value.

After the code scanning the levels, there are error returns that do not
set retval, assuming it is still set to -ENOMEM.

So set retval back to -ENOMEM after scanning the levels.

Fixes: 49cb2fc42ce4 ("fork: extend clone3() to support setting a PID")
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Andrei Vagin <avagin@gmail.com>
Cc: Dmitry Safonov <0x7f454c46@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Adrian Reber <areber@redhat.com>
Cc: <stable@vger.kernel.org> # 5.5
Link: https://lore.kernel.org/r/20200306172314.12232-1-minyard@acm.org
[christian.brauner@ubuntu.com: fixup commit message]
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
kernel/pid.c