busybox: fix missing install with suid bit set if FEATURE_SUID=y
authorHenrique de Moraes Holschuh <henrique@nic.br>
Fri, 18 Oct 2019 11:31:30 +0000 (08:31 -0300)
committerPetr Štetiar <ynezz@true.cz>
Thu, 7 Nov 2019 21:50:16 +0000 (22:50 +0100)
commitad7c6102f2098c3dc8233e4590ac47753dc4900d
treef18aaaa8147b8db2ecdea5bff235babdadd05c63
parent22b8a6263d72bb1911c5841ef90ebdf452b53905
busybox: fix missing install with suid bit set if FEATURE_SUID=y

With FEATURE_SUID=y one can install busybox binary belonging to root
with the suid bit set, enabling some applets to perform root-level
operations even when run by ordinary users. Busybox then drops
privileges for applets that don't need root access, before entering
their main() function.

Currently we don't install busybox binary with suid bit set, rendering
this feature unusable.

Note that we can't just "chmod u+s /bin/busybox" at runtime as a
"cheaper" solution: it would waste approximately 200KiB of FLASH (the
whole /bin/busybox binary gets copied into the overlay).

Ref: PR#2502
Signed-off-by: Henrique de Moraes Holschuh <henrique@nic.br>
[commit title/description facelift, use INSTALL_SUID variable]
Signed-off-by: Petr Štetiar <ynezz@true.cz>
package/utils/busybox/Makefile