udp: consistently apply ufo or fragmentation
authorWillem de Bruijn <willemb@google.com>
Thu, 10 Aug 2017 16:29:19 +0000 (12:29 -0400)
committerDavid S. Miller <davem@davemloft.net>
Thu, 10 Aug 2017 16:52:12 +0000 (09:52 -0700)
commit85f1bd9a7b5a79d5baa8bf44af19658f7bf77bfa
treedcf8a90eb6ae097aa5c962f8bec97e1ce4a5aab7
parent96d9703050a0036a3360ec98bb41e107c90664fe
udp: consistently apply ufo or fragmentation

When iteratively building a UDP datagram with MSG_MORE and that
datagram exceeds MTU, consistently choose UFO or fragmentation.

Once skb_is_gso, always apply ufo. Conversely, once a datagram is
split across multiple skbs, do not consider ufo.

Sendpage already maintains the first invariant, only add the second.
IPv6 does not have a sendpage implementation to modify.

A gso skb must have a partial checksum, do not follow sk_no_check_tx
in udp_send_skb.

Found by syzkaller.

Fixes: e89e9cf539a2 ("[IPv4/IPv6]: UFO Scatter-gather approach")
Reported-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_output.c
net/ipv4/udp.c
net/ipv6/ip6_output.c