FS: cifs, remove unneeded NULL tests
authorJiri Slaby <jslaby@suse.cz>
Mon, 1 Nov 2010 15:08:55 +0000 (16:08 +0100)
committerSteve French <sfrench@us.ibm.com>
Tue, 2 Nov 2010 03:47:21 +0000 (03:47 +0000)
commit50ae28f0144a790fc63a5b89b9aca3ffa9f88522
treeb0e77798ad82428f4f0026cf8f72cc0608ab3223
parentc8ddb2713c624f432fa5fe3c7ecffcdda46ea0d4
FS: cifs, remove unneeded NULL tests

Stanse found that pSMBFile in cifs_ioctl and file->f_path.dentry in
cifs_user_write are dereferenced prior their test to NULL.

The alternative is not to dereference them before the tests. The patch is
to point out the problem, you have to decide.

While at it we cache the inode in cifs_user_write to a local variable
and use all over the function.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Steve French <sfrench@samba.org>
Cc: linux-cifs@vger.kernel.org
Cc: Jeff Layton <jlayton@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Steve French <sfrench@us.ibm.com>
fs/cifs/file.c
fs/cifs/ioctl.c