x86/mm/cpa: In populate_pgd(), don't set the PGD entry until it's populated
authorAndy Lutomirski <luto@kernel.org>
Thu, 14 Jul 2016 20:22:50 +0000 (13:22 -0700)
committerIngo Molnar <mingo@kernel.org>
Fri, 15 Jul 2016 08:26:25 +0000 (10:26 +0200)
commit360cb4d15567a7eca07a5f3ade6de308bbfb4e70
treecc75b47581140c5183b78fdb0a66144907d83073
parentaf2cf278ef4f9289f88504c3e03cb12f76027575
x86/mm/cpa: In populate_pgd(), don't set the PGD entry until it's populated

This avoids pointless races in which another CPU or task might see a
partially populated global PGD entry.  These races should normally
be harmless, but, if another CPU propagates the entry via
vmalloc_fault() and then populate_pgd() fails (due to memory allocation
failure, for example), this prevents a use-after-free of the PGD
entry.

Signed-off-by: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/bf99df27eac6835f687005364bd1fbd89130946c.1468527351.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/mm/pageattr.c