base-files: do not source system.sh in functions.sh
authorAdrian Schmutzler <freifunk@adrianschmutzler.de>
Fri, 13 Mar 2020 15:05:43 +0000 (16:05 +0100)
committerAdrian Schmutzler <freifunk@adrianschmutzler.de>
Sun, 12 Apr 2020 12:16:54 +0000 (14:16 +0200)
commit282e8173509a0907ec469d493f3bd9fed710c453
treed0e9873f7a72bfe0a4042d47a5d30bdf6bbe106d
parentde3e5de8ccfcdbc20c1c2b8798048189b9da6ed5
base-files: do not source system.sh in functions.sh

The default_postinst() function in /lib/functions.sh sources
/lib/functions/system.sh before cycling through uci-defaults files.

This creates a pseudo-cyclic dependency as system.sh also uses
functions that are located in functions.sh. Despite that, there
is actually only one uci-defaults file in the entire repo that needs
system.sh, and this one contains an explicit source for system.sh
anyway.

Consequently, this patch removes the sourcing of system.sh in
functions.sh. There are no relevant uses in packages, routing and
luci repositories.
This may require adjustments for downstream, though.

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
package/base-files/Makefile
package/base-files/files/lib/functions.sh