devmap: Allow map lookups from eBPF
authorToke Høiland-Jørgensen <toke@redhat.com>
Fri, 28 Jun 2019 09:12:35 +0000 (11:12 +0200)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 28 Jun 2019 23:31:09 +0000 (01:31 +0200)
commit0cdbb4b09a0658b72c563638d476113aadd91afb
tree5e29d398bd0fcaac393d22b98ce3f0bc48f49f05
parent43e74c0267a35d6f5127218054b2d80c7fe801f5
devmap: Allow map lookups from eBPF

We don't currently allow lookups into a devmap from eBPF, because the map
lookup returns a pointer directly to the dev->ifindex, which shouldn't be
modifiable from eBPF.

However, being able to do lookups in devmaps is useful to know (e.g.)
whether forwarding to a specific interface is enabled. Currently, programs
work around this by keeping a shadow map of another type which indicates
whether a map index is valid.

Since we now have a flag to make maps read-only from the eBPF side, we can
simply lift the lookup restriction if we make sure this flag is always set.

Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
kernel/bpf/devmap.c
kernel/bpf/verifier.c